Add framerate restriction to the config#2332
Merged
joeyparrish merged 1 commit intoshaka-project:masterfrom Jan 8, 2020
Merged
Add framerate restriction to the config#2332joeyparrish merged 1 commit intoshaka-project:masterfrom
joeyparrish merged 1 commit intoshaka-project:masterfrom
Conversation
joeyparrish
approved these changes
Jan 8, 2020
Member
joeyparrish
left a comment
joeyparrish
left a comment
There was a problem hiding this comment.
Looks good to me! Let me run the tests to verify it.
Collaborator
|
All tests passed! |
joeyparrish
pushed a commit
that referenced
this pull request
Jan 15, 2020
Closes #2068 Backported to v2.5.x Change-Id: I0f29f79117555cd3a013f67bc5882d1a00f7f3ac
Member
|
This PR has been cherry-picked for v2.5.8. |
shaka-bot
pushed a commit
that referenced
this pull request
Apr 27, 2020
This is only defined on Stream, not Variant. This bug has was introduced in PR #2332 and the v2.5.8 release and affects v2.5.8 - v2.5.10. The corresponding feature (frameRate restrictions) has actually never worked. This was caught by a compiler upgrade which is still in progress. Change-Id: I0409d9be8d3f6eb0794775ca29f28b98208bab4f
joeyparrish
added a commit
that referenced
this pull request
May 1, 2020
This is only defined on Stream, not Variant. This bug has was introduced in PR #2332 and the v2.5.8 release and affects v2.5.8 - v2.5.10. The corresponding feature (frameRate restrictions) has actually never worked. This was caught by a compiler upgrade which is still in progress. Backported to v2.5.x Change-Id: I0409d9be8d3f6eb0794775ca29f28b98208bab4f
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2068