Make trackSelectionCallback async#2387
Merged
joeyparrish merged 1 commit intoshaka-project:masterfrom Feb 12, 2020
Merged
Conversation
joeyparrish
approved these changes
Feb 12, 2020
Member
joeyparrish
left a comment
joeyparrish
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks!
Collaborator
|
All tests passed! |
Member
|
Thanks for your contribution! |
joeyparrish
pushed a commit
that referenced
this pull request
Mar 11, 2020
Resolves #2383 Backported to v2.5.x Change-Id: I8aa60585e69f121535e41dccf04455345cbb68c3
joeyparrish
added a commit
that referenced
this pull request
Mar 11, 2020
PR #2387 introduced a bug. It awaited the track selection callback, but that was done in a loop, the results of which were not awaited. This would cause storage to continue before the complete list of tracks was available. Closes #2383 Backported to v2.5.x Change-Id: I18a429cf0f40b829020c520c622ffdae8b12622e
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2383