Add creationTime to offline assets#2406
Merged
joeyparrish merged 4 commits intoshaka-project:masterfrom Apr 10, 2020
Merged
Conversation
Member
|
I'm going to put this on hold until we complete #1339, in which I am changing the offline structure in more severe ways. After that, we can add creationTime to the new format and back-fill NaN or something for existing stored content. |
Member
|
@avelad, the changes I had planned in the manifest are now complete. Can you please rebase and let me know when it's ready for another review? |
joeyparrish
requested changes
Apr 9, 2020
| const V1StorageCell = shaka.offline.indexeddb.V1StorageCell; | ||
|
|
||
| return { | ||
| creationTime: old.creationTime || 0, |
Member
There was a problem hiding this comment.
This won't exist in the old format, so you can just fill in 0 or NaN. After you rebase, you'll need this in v2_storage_cell as well. We've moved to a new database format.
Member
Author
|
@joeyparrish It's ready to review again! |
joeyparrish
approved these changes
Apr 10, 2020
Member
joeyparrish
left a comment
joeyparrish
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
Collaborator
|
All tests passed! |
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.