Add loaded event to the player

[avelad]

Add a new event in the player that indicate that the load is complete.

This is necessary for SS ADS because it does the player.load process.

[joeyparrish]

Looks reasonable. Can you give us a little more detail on why SS ads needs this event?

[shaka-bot]

All tests passed!

[avelad]

The SS manage by it self the load in https://github.com/google/shaka-player/blob/master/lib/ads/server_side_ad_manager.js#L293

In my app logic I need get the resolved promise for execute some actions. Due that now there are not promise, I need a event for execute the actions

[joeyparrish]

I'll go ahead and merge this, but is there any need for a corresponding Promise from the ad manager?

[avelad]

With this change is not necessary a promise (for me, i don't know other use cases...)

[avelad]

@joeyparrish , Why do you appear as the creator of the commit?

57ce383

[joeyparrish]

I'm not sure. I just clicked the merge button in GitHub's PR interface.

[joeyparrish]

Looking at the details in the git log, it looks like GitHub did something odd:

commit 57ce383b389467bf7cf82ae10ad9f93c75dfecd1
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Commit: GitHub <noreply@github.com>

Normally, I would expect to see you as the author, as I do in this one:

commit c6323248803b590713bfdf3cf06194c0c3c13059
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Commit: GitHub <noreply@github.com>

Perhaps you should raise an issue with GitHub support. I'm not sure what I could have done differently on my end.

[joeyparrish]

It looks like this has happened before, but not recently:

$ git log --pretty=full | grep -B 1 'Commit: GitHub' | grep Author
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Tomohiro Matsuzawa (Tomo) <thmatuza75@hotmail.com>
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Author: Brian Harris <brianfromoregon@gmail.com>
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Author: Tijn Porcelijn <porcelijn@gmail.com>
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Author: LanaIV <LanaIV@users.noreply.github.com>
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>
Author: Joey Parrish <joeyparrish@users.noreply.github.com>

And if you dig, there are even more PRs that don't show GitHub as the commiter:

commit 6e8ab0132fa2b04d5cfc15a18165ec7c0a9b6a83
Author: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Commit: Joey Parrish <joeyparrish@users.noreply.github.com>

commit c6f0a86d7399c8fa0fa08a5f3e8cc3aa7e13834e
Author: Leon Chen <leonhart.chen@gmail.com>
Commit: Joey Parrish <joeyparrish@users.noreply.github.com>

I'm sorry I don't understand what's happening. We would prefer you have full credit in the commit log, of course. You've contributed a lot to this project, and we're very grateful.

[avelad]

I just wanted to know what could have happened. No problem in not appearing as an author, I prefer to have the functionality :)

Thanks!

[joeyparrish]

We use the "squash & merge" feature in this repo, so it's possible that has something to do with it. But I don't see a difference in behavior that I could tie to squashing. For example, #2400 (2 commits) and #2408 (1 commit) both have the correct info.

In any case, thanks again for your contributions!

[avelad]

With the new commit 7b80252 there is the same issue

[joeyparrish]

Yes, I noticed that. I went through the dialog carefully that time, and there wasn't anything different I could have done as far as I can tell.