Skip to content

Add AirPlay button to overflow menu #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theodab merged 4 commits into from
Jul 14, 2020
Merged

Add AirPlay button to overflow menu #2701

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2074eaa
Add AirPlay button to overflow menu
Jun 30, 2020
7c9e7b0
Add button to the list of UI buttons
Jul 8, 2020
95df511
Move airplay button to default config
Jul 8, 2020
897fa47
Change button name
Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move airplay button to default config
  • Loading branch information
Alvaro Velad committed Jul 8, 2020
commit 95df511c490f82c72979a54e56f0ec522adeaaff
10 changes: 5 additions & 5 deletions ui/ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,6 @@ shaka.ui.Overlay = class {

goog.asserts.assert(this.player_ != null, 'Should have a player!');

// Check AirPlay support
if (window.WebKitPlaybackTargetAvailabilityEvent) {
this.config_.overflowMenuButtons.push('airplay');
}

this.controls_.configure(this.config_);

this.controls_.dispatchEvent(new shaka.util.FakeEvent('uiupdated'));
Expand Down Expand Up @@ -208,6 +203,11 @@ shaka.ui.Overlay = class {
forceLandscapeOnFullscreen: true,
};

// Check AirPlay support
if (window.WebKitPlaybackTargetAvailabilityEvent) {
config.overflowMenuButtons.push('airplay');
}

// On mobile, by default, hide the volume slide and the small play/pause
// button and show the big play/pause button in the center.
// This is in line with default styles in Chrome.
Expand Down