Adds VTT tag rendering for <b>, <i> and <u>#2776
Merged
joeyparrish merged 12 commits intoshaka-project:masterfrom Aug 11, 2020
Merged
Adds VTT tag rendering for <b>, <i> and <u>#2776joeyparrish merged 12 commits intoshaka-project:masterfrom
joeyparrish merged 12 commits intoshaka-project:masterfrom
Conversation
TheModMaker
suggested changes
Aug 10, 2020
joeyparrish
requested changes
Aug 10, 2020
added 5 commits
August 10, 2020 19:10
This reverts commit 2027f0c.
Member
Author
|
I updated the PR with the addressed comments |
joeyparrish
requested changes
Aug 11, 2020
Member
joeyparrish
left a comment
joeyparrish
left a comment
There was a problem hiding this comment.
We just committed changes to Cue, the text displayers, and a few other text-related classes. There may be some minor merge conflicts.
Collaborator
|
All tests passed! |
Closed
joeyparrish
pushed a commit
that referenced
this pull request
Aug 11, 2020
percytse-harmonic
pushed a commit
to harmonicinc-com/shaka-player
that referenced
this pull request
Sep 11, 2020
|
When this enhancement can be expected to be released? |
Member
|
@ScripterYoda, this will be released in v3.1, which is currently blocked on some TTML issues that I introduced during the CEA work (sorry!) and @michellezhuogg is actively working on fixing (thanks!) |
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the work of #2724, changing the implementation according to #2724 (comment)
Solve #2348