Skip to content

fix: Fix case sensitivity for drm content type#2800

Merged
joeyparrish merged 1 commit intoshaka-project:masterfrom
Stansbridge:fix/drm-content-type-case-sensitivity-bug
Aug 20, 2020
Merged

fix: Fix case sensitivity for drm content type#2800
joeyparrish merged 1 commit intoshaka-project:masterfrom
Stansbridge:fix/drm-content-type-case-sensitivity-bug

Conversation

@Stansbridge
Copy link
Contributor

@Stansbridge Stansbridge commented Aug 14, 2020

This fixes the case sensitivity in the DrmEngine willSupport method. This comparison should be case insensitive, particularly for codec profiles described in hex which may be either lower or upper case. The change normalizes both the stored content types and the method arguments.

edit: Will likely target this for 2.5 as this release is the one directly affecting me.

Closes #2799

This fixes the case sensitivity in the `DrmEngine` `willSupport` method. This comparison should be case insensitive, particularly for codec profiles described in hex which may be either lower or upper case. The change normalizes both the stored content types and the method arguments.

Closes shaka-project#2799
@google-cla
Copy link

google-cla bot commented Aug 14, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Stansbridge
Copy link
Contributor Author

@googlebot I signed it!

@Stansbridge
Copy link
Contributor Author

Closing this while I investigate a subsequent issue

@Stansbridge Stansbridge reopened this Aug 17, 2020
@joeyparrish joeyparrish merged commit 8b36acf into shaka-project:master Aug 20, 2020
@joeyparrish
Copy link
Member

This can be cherry-picked to v2.5.x and v3.0.x. Thank you!

joeyparrish pushed a commit that referenced this pull request Aug 25, 2020
This fixes the case sensitivity in the `DrmEngine` `willSupport` method. This comparison should be case insensitive, particularly for codec profiles described in hex which may be either lower or upper case. The change normalizes both the stored content types and the method arguments.

Closes #2799

Backported to v2.5.x

Change-Id: If38d2aadc5d5aac09e55f1a3a0faaf2f2f2b4a26
joeyparrish pushed a commit that referenced this pull request Aug 25, 2020
This fixes the case sensitivity in the `DrmEngine` `willSupport` method. This comparison should be case insensitive, particularly for codec profiles described in hex which may be either lower or upper case. The change normalizes both the stored content types and the method arguments.

Closes #2799
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: archived Archived and locked; will not be updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect variant filtering on codec profile for multi period manifests

3 participants