feat: deduplicate text streams in period flattening#2885
Merged
joeyparrish merged 4 commits intoshaka-project:masterfrom Oct 1, 2020
Merged
feat: deduplicate text streams in period flattening#2885joeyparrish merged 4 commits intoshaka-project:masterfrom
joeyparrish merged 4 commits intoshaka-project:masterfrom
Conversation
joeyparrish
requested changes
Sep 30, 2020
Member
joeyparrish
left a comment
There was a problem hiding this comment.
Looks good otherwise. Thanks!
test/util/periods_unit.js
Outdated
| a3.bandwidth = 97065; | ||
| a2.roles = ['role1', 'role2']; | ||
|
|
||
| // t1 and t3 are duplicats |
Member
There was a problem hiding this comment.
Minor nit: typo on "duplicates"
Larger concern: the test has no expectations on the text streams, so it would pass even without your code change. Please add a check to the end of the test to show that t3 was filtered out. Thanks!
Contributor
Author
There was a problem hiding this comment.
Didn't see that one 😅
Collaborator
|
Test Failure: |
joeyparrish
approved these changes
Oct 1, 2020
Collaborator
|
All tests passed! |
joeyparrish
pushed a commit
that referenced
this pull request
Oct 1, 2020
Similar to what was already done for audio streams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title said it all :)
In a multi-period stream with the same text streams over periods, we would get back duplicates text tracks when calling
getTextTracksplayer API.That PR should fix that behaviour.