Skip to content

Management of forced subtitles#3022

Merged
joeyparrish merged 6 commits intoshaka-project:masterfrom
avelad:management-forced-subtitles
Dec 17, 2020
Merged

Management of forced subtitles#3022
joeyparrish merged 6 commits intoshaka-project:masterfrom
avelad:management-forced-subtitles

Conversation

@avelad
Copy link
Member

@avelad avelad commented Dec 3, 2020

Closes: #2947

joeyparrish
joeyparrish reviewed Dec 3, 2020
View reviewed changes
externs/shaka/player.js Outdated
Comment on lines +954 to +955
* @property {boolean} preferredTextLanguageForced
* If true, a forced text track is preferred. Defaults to false.
Copy link
Member

@joeyparrish joeyparrish Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not understand the meaning of this flag from the name alone. Now that I am reading the description, I feel like "preferForcedSubs" would make more sense.

Also, can you please clarify the behavior in combination with other settings? For example, it seems like this is to choose between multiple tracks with the same language and different "forced" settings. So, if my content has en & en-forced, and I prefer en, this flag controls which one I get. But if my content has en & fr & en-forced, and I prefer fr, this flag won't have any effect. Is that correct?

Copy link
Member Author

@avelad avelad Dec 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the name, I have put a more detailed description and I have added a new test to make everything clearer.

@avelad avelad requested a review from joeyparrish December 4, 2020 07:15
@avelad
Copy link
Member Author

avelad commented Dec 16, 2020

@joeyparrish can you review it?

joeyparrish
joeyparrish requested changes Dec 17, 2020
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@avelad avelad requested a review from joeyparrish December 17, 2020 06:59
@shaka-bot
Copy link
Collaborator

shaka-bot commented Dec 17, 2020

All tests passed!

@shaka-bot
Copy link
Collaborator

shaka-bot commented Dec 17, 2020

All tests passed!

@joeyparrish joeyparrish merged commit e5bf027 into shaka-project:master Dec 17, 2020
@avelad avelad deleted the management-forced-subtitles branch December 18, 2020 07:40
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees

No one assigned

Labels

status: archived Archived and locked; will not be updated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Management of forced subtitles

3 participants

@avelad @shaka-bot @joeyparrish