Optionally force HTTPS content URIs#3025
Merged
joeyparrish merged 7 commits intoshaka-project:masterfrom Dec 17, 2020
Merged
Conversation
joeyparrish
requested changes
Dec 3, 2020
demo/config.js
Outdated
| const prefix = category + '.retryParameters.'; | ||
| const docLink = this.resolveExternLink_('.RetryParameters'); | ||
| this.addSection_(sectionName, docLink) | ||
| .addBoolInput_(MessageIds.FORCE_HTTPS, prefix + 'forceHTTPs') |
Member
There was a problem hiding this comment.
I don't think this belongs in the retry parameters section.
Member
Author
There was a problem hiding this comment.
If you tell me which section it should belong to, I will make the change.
Contributor
There was a problem hiding this comment.
You can put it in the streaming section.
Member
Author
|
@joeyparrish can you review it? |
joeyparrish
approved these changes
Dec 17, 2020
Collaborator
|
All tests passed! |
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1389