Add navigator.storage.estimate polyfill#3050
Merged
TheModMaker merged 7 commits intoshaka-project:masterfrom Jan 20, 2021
Merged
Add navigator.storage.estimate polyfill#3050TheModMaker merged 7 commits intoshaka-project:masterfrom
TheModMaker merged 7 commits intoshaka-project:masterfrom
Conversation
Member
Author
|
I have the following problem with closure, hope you can help me: |
TheModMaker
reviewed
Dec 15, 2020
joeyparrish
reviewed
Dec 15, 2020
lib/polyfill/storage_estimate.js
Outdated
| return; | ||
| } | ||
|
|
||
| if ('webkitTemporaryStorage' in navigator && |
Member
There was a problem hiding this comment.
Is there any additional fallback that can be done without the prefixed version? Or do you plan to check existence again before using the API in the library?
Member
Author
There was a problem hiding this comment.
This is the old API and the final version is navigator.storage.estimate (it is similar to pip_webkit polyfill)
joeyparrish
reviewed
Dec 15, 2020
added 3 commits
December 15, 2020 20:02
TheModMaker
approved these changes
Jan 19, 2021
Collaborator
|
Test Failure: |
Contributor
|
That is caused by #3102 and can be solved by rebasing your change on the latest |
Member
Author
|
Done. @TheModMaker , can you test again? |
Collaborator
|
All tests passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #2900