Allow test Edge Chromium with Karma#3265
Merged
joeyparrish merged 2 commits intoshaka-project:masterfrom Mar 30, 2021
Merged
Conversation
michellezhuogg
approved these changes
Mar 26, 2021
Member
Author
|
@michellezhuogg can you run the Shaka-bot? |
Collaborator
|
All tests passed! |
|
Sir I was willing to contribute to this project but am not able to set it up on my local environment and I was not able to find proper instructions about it. Can anyone guide me regarding this? |
Member
Author
|
@Ra-Won Please open a question type issue for this. Thank you. |
Contributor
|
@avelad, Sorry about that. Hello @Ra-Won, to start, checkout our demo and tutorial page. You can see more details in the doc. |
joeyparrish
pushed a commit
that referenced
this pull request
Apr 22, 2021
joeyparrish
pushed a commit
that referenced
this pull request
Apr 25, 2021
Backported to v2.5.x Change-Id: I83f8384111e8e46ee559028ead55300f5c0f6736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change it is possible to run the tests in Edge Chromium by default.
Karma needs to be updated to allow wildcard scoped packages to be used by default, see: karma-runner/karma#3659
Test results on macOS: