fixes(hls): adds fallback to MP4 in case the Mime type is not identified by parser by surajkumar-sk · Pull Request #3325 · shaka-project/shaka-player

surajkumar-sk · 2021-04-12T20:57:33Z

Description

#3142

Screenshots (optional)

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

I have signed the Google CLA https://cla.developers.google.com
My code follows the style guidelines of this project
I have verified my change on multiple browsers on different platforms
I have run ./build/all.py and the build passes
I have run ./build/test.py and all tests pass

lib/hls/hls_parser.js

surajkumar-sk · 2021-04-13T16:22:15Z

I saw people adding names to the contributor's list and authors list. Do I qualify to add my name to the list

joeyparrish · 2021-04-13T16:22:26Z

test/hls/hls_parser_unit.js

          .toBeRejectedWith(Util.jasmineError(error));
    }

-    it('if unable to guess mime type', async () => {


Can you please add a new test case for the fallback to mp4? You could use this as a template, but the new test should not be nested within describe('Errors out', () => {

Thanks!

joeyparrish · 2021-04-13T16:33:16Z

I saw people adding names to the contributor's list and authors list. Do I qualify to add my name to the list

Sure. You can add your name in this PR.

The list hasn't been perfectly maintained over the years, and new projects at Google don't have CONTRIBUTORS files at all. So the source of truth for who is a contributor is actually the commit log.

Because the list has been poorly-maintained for so long, it may be replaced by some other system of acknowledgement in the future.

joeyparrish · 2021-04-13T18:11:46Z

Here's the longer reply. You may regret asking me such a loaded question. 😄

you already knew how to fix this issue, the changes were pretty small so why didn't you finish solving it?

We are a small team at Google. There are currently only 3 people working full-time on Shaka Player, and for reasons I can't really get into, we spent a few months recently with only 1 person working on the project full-time.

As the core team of maintainers, we are working on a few high-priority features, while also fixing bugs, and managing issues and PRs. We're doing about as much as we possibly can by ourselves. So everything else is left to the Shaka Player community.

This particular issue is a low priority for us. The issue only affects servers that don't support HEAD requests (which are these anyway?) serving content that has no recognizable file extension. But for a service provider with this exact setup, it would be a higher priority for them.

The beauty of open source is that you can have very different priorities from us. If you care about something enough, you can read and modify the source to get what you want.

As maintainers, the best thing we can do to get the most done on the project is to be available to provide expertise, to coach and guide contributors, and to help them identify solutions. Perhaps one of us could have done this particular thing more quickly, but by helping members of the community contribute to the issues they care about, we're getting more done overall in parallel.

I was just curious like this is your project and you are striving to make it perfect

I don't think we can make it perfect. Though you remind me of two sayings that I love:

"A work is never truly completed, but abandoned."

Shaka Player will never be "done", because requirements will always change and no project will ever be bug-free. But some day the world may lose interest, or the project may no longer be needed. We'll make it as good as we can, for as long as we can, but some day this project will die, as all projects will.

"The perfect is the enemy of the good enough."

We will never be bug-free, strive as we might. And we will never have the perfect feature set for every user. In fact, some users want us to remove features that others see as a requirement. We literally can't be the best solution for everyone. Since perfection is unachievable, it's important to decide where we settle, and what "good enough" means for us, and not obsess over what we can't get done. Some issues will remain on the backlog until they become important enough for us to devote our limited time to them, or until someone like you comes along who has the time and energy to work on them.

I hope this is useful context, and that you'll forgive me for being so long-winded. 😄

joeyparrish

Looks good to me otherwise. Thanks!

joeyparrish · 2021-04-13T18:14:09Z

test/hls/hls_parser_unit.js

    await testHlsParser(master, media, manifest);
  });

+  it('if unable to guess mime type through Header Request', async () => {


The name of this test doesn't make sense. In the previous version, it was inside a describe called "Errors out", leading to the complete name "Errors out if ..."

Here, this might be a better name: it('falls back to mp4 if HEAD request fails'

Though we sometimes break this rule a bit, in Jasmine, the "it" functions should read like a sentence about the thing under test: "it falls back to mp4 if ..."

surajkumar-sk · 2021-04-13T18:32:11Z

@joeyparrish

"A work is never truly completed, but abandoned."
Shaka Player will never be "done", because requirements will always change and no project will ever be bug-free. But some day the world may lose interest, or the project may no longer be needed. We'll make it as good as we can, for as long as we can, but some day this project will die, as all projects will.

These lines hit very differently, it felt very emotional.

I hope this is useful context, and that you'll forgive me for being so long-winded.

That's definitely useful.

and I don't know why the inner me pronounces those sentences as a prophet giving a lecture about a divine event. 😂

Thank you for taking the time and replying.

joeyparrish · 2021-04-13T18:37:57Z

Shaka Player will never be "done" ... some day this project will die, as all projects will.

These lines hit very differently, it felt very emotional.

I'm an emotional guy! This will be me when I leave the project some day: 😭🤙

joeyparrish

Thanks!

surajkumar-sk · 2021-04-13T18:42:18Z

Hope the thing for which you will leave this project, will be worth it. 😊

joeyparrish · 2021-04-13T18:46:25Z

Hope the thing for which you will leave this project, will be worth it. 😊

How about retirement?

surajkumar-sk · 2021-04-13T18:54:17Z

well, you can still join our group of contributors. but I don't know about how retirement might feel, if it's worth it or not, I am still a student who is figuring out his youth. that's probably a question you yourself should answer. 😊

joeyparrish · 2021-04-13T18:56:09Z

well, you can still join our group of contributors. but I don't know about how retirement might feel, if it's worth it or not, I am still a student who is figuring out his youth. that's probably a question you yourself should answer. 😊

Plan ahead, I always say. 😄

surajkumar-sk · 2021-04-13T19:04:21Z

I can't even if I want to. There are just so many technologies that interest me that I think I'll probably never retire. 😵
I belong to a generation who grew watching marvel and dc, and both of them don't have a concept of retirement 😂

shaka-bot · 2021-04-13T19:08:02Z

All tests passed!

joeyparrish · 2021-04-13T20:55:22Z

I belong to a generation who grew watching marvel and dc, and both of them don't have a concept of retirement 😂

Not true! Cap retired. (Spoiler)

joeyparrish · 2021-04-13T20:56:12Z

Thanks for your contribution!

surajkumar-sk · 2021-04-13T21:29:18Z

Yeah he did, but he is a soldier(a good man), thanos too.. let me change my statement .
Marvel and dc doesn't have a concept of retirement for people who crave knowledge. 😅

Fixes #3142 Backported to v3.0.x Change-Id: I09a48c30e76da5a4a93d58263d3a94abf7ed69ed

Fixes #3142 Backported to v2.5.x Change-Id: I8980cf47f16de50827c42cfebad7c67792156481

joeyparrish requested changes Apr 12, 2021

View reviewed changes

lib/hls/hls_parser.js Outdated Show resolved Hide resolved

surajkumar-sk requested a review from joeyparrish April 13, 2021 06:57

fixes #3142

a06bec9

joeyparrish requested changes Apr 13, 2021

View reviewed changes

lib/hls/hls_parser.js Show resolved Hide resolved

surajkumar-sk requested a review from joeyparrish April 13, 2021 15:47

joeyparrish requested changes Apr 13, 2021

View reviewed changes

surajkumar-sk requested a review from joeyparrish April 13, 2021 18:05

joeyparrish requested changes Apr 13, 2021

View reviewed changes

added tests

2603725

surajkumar-sk requested a review from joeyparrish April 13, 2021 18:35

joeyparrish approved these changes Apr 13, 2021

View reviewed changes

changed name

24dce6b

surajkumar-sk added 2 commits April 13, 2021 12:17

Updated changes

26f3351

updated changes

baa5413

joeyparrish merged commit 7714099 into shaka-project:master Apr 13, 2021

surajkumar-sk deleted the hls branch April 14, 2021 05:49

joeyparrish pushed a commit that referenced this pull request Apr 22, 2021

fix(hls): Assume MP4 if MIME type can't be deduced (#3325)

6d44bd4

Fixes #3142 Backported to v3.0.x Change-Id: I09a48c30e76da5a4a93d58263d3a94abf7ed69ed

joeyparrish pushed a commit that referenced this pull request Apr 25, 2021

fix(hls): Assume MP4 if MIME type can't be deduced (#3325)

c4450aa

Fixes #3142 Backported to v2.5.x Change-Id: I8980cf47f16de50827c42cfebad7c67792156481

github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023

github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023

Conversation

surajkumar-sk commented Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshots (optional)

Type of change

Checklist:

Uh oh!

Uh oh!

Uh oh!

surajkumar-sk commented Apr 13, 2021

Uh oh!

joeyparrish Apr 13, 2021

Choose a reason for hiding this comment

Uh oh!

joeyparrish commented Apr 13, 2021

Uh oh!

joeyparrish commented Apr 13, 2021

Uh oh!

joeyparrish left a comment

Choose a reason for hiding this comment

Uh oh!

joeyparrish Apr 13, 2021

Choose a reason for hiding this comment

Uh oh!

surajkumar-sk Apr 13, 2021

Choose a reason for hiding this comment

Uh oh!

surajkumar-sk commented Apr 13, 2021

Uh oh!

joeyparrish commented Apr 13, 2021

Uh oh!

joeyparrish left a comment

Choose a reason for hiding this comment

Uh oh!

surajkumar-sk commented Apr 13, 2021

Uh oh!

joeyparrish commented Apr 13, 2021

Uh oh!

surajkumar-sk commented Apr 13, 2021

Uh oh!

joeyparrish commented Apr 13, 2021

Uh oh!

surajkumar-sk commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shaka-bot commented Apr 13, 2021

Uh oh!

joeyparrish commented Apr 13, 2021

Uh oh!

joeyparrish commented Apr 13, 2021

Uh oh!

surajkumar-sk commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

surajkumar-sk commented Apr 12, 2021 •

edited

Loading

surajkumar-sk commented Apr 13, 2021 •

edited

Loading

surajkumar-sk commented Apr 13, 2021 •

edited

Loading