Append segment chunk strictly in order#3405
Merged
joeyparrish merged 3 commits intoshaka-project:masterfrom May 17, 2021
Merged
Append segment chunk strictly in order#3405joeyparrish merged 3 commits intoshaka-project:masterfrom
joeyparrish merged 3 commits intoshaka-project:masterfrom
Conversation
joeyparrish
requested changes
May 13, 2021
| loaded += readObj.value.byteLength; | ||
| if (streamDataCallback) { | ||
| streamDataCallback(readObj.value); | ||
| await streamDataCallback(readObj.value); |
Member
There was a problem hiding this comment.
I see the callback in StreamingEngine is async, so this makes sense. But can you also please change the signature of the callback accordingly?
/**
* @param {?function(BufferSource):!Promise} streamDataCallback
*/
Member
There was a problem hiding this comment.
Could you please do this in the entire codebase? There are others in lib/util/, lib/net/, externs/, etc. Thanks!
joeyparrish
requested changes
May 14, 2021
| loaded += readObj.value.byteLength; | ||
| if (streamDataCallback) { | ||
| streamDataCallback(readObj.value); | ||
| await streamDataCallback(readObj.value); |
Member
There was a problem hiding this comment.
Could you please do this in the entire codebase? There are others in lib/util/, lib/net/, externs/, etc. Thanks!
joeyparrish
added
the
priority: P1
joeyparrish
approved these changes
May 17, 2021
Collaborator
|
All tests passed! |
ismena
pushed a commit
that referenced
this pull request
May 17, 2021
An async process handles the appending of partial segments for LL-DASH. This fixes the caller to wait on the results, so that partial segments are always appended in order. Fixes #3404
1 task
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3404
Screenshots (optional)
Type of change
not work as expected)
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass