Fix audio language switching while using AirPlay#3472
Merged
joeyparrish merged 1 commit intoshaka-project:masterfrom Jun 22, 2021
Merged
Fix audio language switching while using AirPlay#3472joeyparrish merged 1 commit intoshaka-project:masterfrom
joeyparrish merged 1 commit intoshaka-project:masterfrom
Conversation
When sending a video to an AirPlay target, such as an Apple TV or a TV with AirPlay built in, it can become impossible to change from one audio language, to a second audio language, then return to the first audio language. When enabling a new audio track, it is assumed that all other tracks will be disabled. However, while sending media to the AirPlay target, no tracks are automatically disabled. As a result, it would become impossible to reselect certain audio tracks as the player would keep playing an enabled track, even if it isn't the most recently enabled track. Issue shaka-project#3125
joeyparrish
approved these changes
Jun 22, 2021
Collaborator
|
All tests passed! |
joeyparrish
pushed a commit
that referenced
this pull request
Jul 13, 2021
When sending a video to an AirPlay target, such as an Apple TV or a TV with AirPlay built in, it can become impossible to change from one audio language, to a second audio language, then return to the first audio language. When enabling a new audio track, it is assumed that all other tracks will be disabled. However, while sending media to the AirPlay target, no tracks are automatically disabled. As a result, it would become impossible to reselect certain audio tracks as the player would keep playing an enabled track, even if it isn't the most recently enabled track. Closes #3125
joeyparrish
pushed a commit
that referenced
this pull request
Jul 13, 2021
When sending a video to an AirPlay target, such as an Apple TV or a TV with AirPlay built in, it can become impossible to change from one audio language, to a second audio language, then return to the first audio language. When enabling a new audio track, it is assumed that all other tracks will be disabled. However, while sending media to the AirPlay target, no tracks are automatically disabled. As a result, it would become impossible to reselect certain audio tracks as the player would keep playing an enabled track, even if it isn't the most recently enabled track. Closes #3125 Backported to v3.0.x Change-Id: I84c383bb2aef9a308d31ef95614492d14bee3942
1 task
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sending a video to an AirPlay target, such as an Apple TV or a TV
with AirPlay built in, it can become impossible to change from one
audio language, to a second audio language, then return to the first
audio language.
When enabling a new audio track, it is assumed that
all other tracks will be disabled. However, while sending media to the
AirPlay target, no tracks are automatically disabled. As a result, it
would become impossible to reselect certain audio tracks as the player
would keep playing an enabled track, even if it isn't the most recently
enabled track.
Issue #3125
Description
Screenshots (optional)
Type of change
not work as expected)
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass