Fix: selectVariantTrack doesn't clear buffer if already selected

[avelad]

Close: #3450

[michellezhuogg]

1. Would you please add "force" to the param list?
2. Would you please leave a comment to explain how "force" works with "clearBuffer"?

[avelad]

Done!

[shaka-bot]

All tests passed!

[joeyparrish]

Thanks for your contributions!

[aradalvand]

Thanks for this. Was adding a new parameter necessary though? Couldn't this be the default behavior when clearBuffer is true? As @TheModMaker had said in #3450:

I guess we should probably always clear the buffer if the clearBuffer argument is set. This may result in some extra work if the app calls for an already-selected track; but it is probably more correct to trust the app and clear the buffer.

[joeyparrish]

Thanks for this. Was adding a new parameter necessary though? Couldn't this be the default behavior when clearBuffer is true?

Yes, and yes. The new parameter was on an internal class (StreamingEngine), not on selectVariantTrack. When clearBuffer is true on selectVariantTrack, it now does what you would expect. It uses this new internal parameter on StreamingEngine to do the job.

[aradalvand]

@joeyparrish Oh yeah, that's right, sorry! I mistakenly thought the new parameter was on selectVariantTrack.
Thanks!

[joeyparrish]

No problem! It's an easy mistake to make. Thanks for using Shaka Player!