Add support for efficient preprocessing of DASH manifests after parsing into an XMLDocument#3480
Merged
joeyparrish merged 1 commit intoshaka-project:masterfrom Jun 22, 2021
Conversation
…ing into an XMLDocument, configured with manifest.dash.manifestPreprocessor
joeyparrish
reviewed
Jun 22, 2021
Collaborator
|
All tests passed! |
joeyparrish
approved these changes
Jun 22, 2021
Contributor
Author
|
@joeyparrish can this be cherry picked into v3.0.x and v3.1.x ? |
Member
|
Since v3.0.0, we are following Semantic Versioning closely. This means all new features require a minor version bump, and can't be cherry-picked into older release branches. |
1 task
caridley
added a commit
to caridley/shaka-player
that referenced
this pull request
Aug 25, 2022
…ect#3480) Added support for efficient preprocessing of DASH manifest after they have been parsed into an XMLDocument This is configured with the new manifest.dash.manifestPreprocessor setting. This is need to efficiently repair manifests that are not compatible with Shaka Player. Closes shaka-project#3339 (cherry picked from commit 9afa4eb)
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements #3339
Added support for efficient preprocessing of DASH manifest after they have been parsed into an XMLDocument
This is configure with the new manifest.dash.manifestPreprocessor setting.
This is need to efficiently repair manifests that are not compatible with Shaka player.
Type of change
Documentation for DashManifestConfiguration changes
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass