Skip to content

Fix: Replay button does not have correct aria-label#3513

Merged
joeyparrish merged 3 commits intoshaka-project:masterfrom
avelad:replay-aria-label
Jul 8, 2021
Merged

Fix: Replay button does not have correct aria-label#3513
joeyparrish merged 3 commits intoshaka-project:masterfrom
avelad:replay-aria-label

Conversation

@avelad
Copy link
Member

@avelad avelad commented Jul 8, 2021

Close: #3512

@avelad
Copy link
Member Author

avelad commented Jul 8, 2021

One question: who generates the rest of the missing translations? (there are 44 languages I think and I have only added one...)

@avelad avelad requested a review from joeyparrish July 8, 2021 20:14
@joeyparrish
Copy link
Member

One question: who generates the rest of the missing translations? (there are 44 languages I think and I have only added one...)

We have an internal process at Google to request official translations from pro translators. I'll make a note to start that process for the new strings. Thanks for reminding me!

@shaka-bot
Copy link
Collaborator

Test Failure:

Generating Closure dependencies...
Linting JavaScript...
Linting CSS...
Linting HTML...

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Scanned 3 files, no errors found (40 ms).
Checking that the build files are complete...
Checking for common misspellings...
Checking correct usage of eslint-disable...
Checking the tests for type errors...
No changes detected, skipping. Use --force to override.
Building the docs...
Compiling the library (ui, debug)...
No changes detected, skipping. Use --force to override.
/var/lib/jenkins/workspace/Manual PR Test (local-tests)/ui/big_play_button.js:47:36: ERROR - [JSC_MISSING_REQUIRE_IN_PROVIDES_FILE] 'shaka.ui.Locales' references a namespace which was not required by this file.
Please add a goog.require.
47|     const LocIds = shaka.ui.Locales.Ids;
^^^

1 error(s), 0 warning(s), 92.2% typed
Build failed
END-BUILD: FAILURE
Build step 'Execute shell' marked build as failure

@avelad
Copy link
Member Author

avelad commented Jul 8, 2021

Fixed! Sorry :(

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 2dedd9f into shaka-project:master Jul 8, 2021
@avelad avelad deleted the replay-aria-label branch July 9, 2021 05:28
joeyparrish pushed a commit that referenced this pull request Jul 13, 2021
joeyparrish pushed a commit that referenced this pull request Jul 13, 2021
Close: #3512

Backported to v3.0.x

Change-Id: I20df8c4b9cf621dad75f4d981bd04571fcaf481e
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: archived Archived and locked; will not be updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replay button does not have correct aria-label

3 participants