Fix: Replay button does not have correct aria-label#3513
Merged
joeyparrish merged 3 commits intoshaka-project:masterfrom Jul 8, 2021
Merged
Fix: Replay button does not have correct aria-label#3513joeyparrish merged 3 commits intoshaka-project:masterfrom
joeyparrish merged 3 commits intoshaka-project:masterfrom
Conversation
Member
Author
|
One question: who generates the rest of the missing translations? (there are 44 languages I think and I have only added one...) |
joeyparrish
reviewed
Jul 8, 2021
Member
We have an internal process at Google to request official translations from pro translators. I'll make a note to start that process for the new strings. Thanks for reminding me! |
joeyparrish
approved these changes
Jul 8, 2021
Collaborator
|
Test Failure: |
Member
Author
|
Fixed! Sorry :( |
joeyparrish
approved these changes
Jul 8, 2021
Collaborator
|
All tests passed! |
joeyparrish
pushed a commit
that referenced
this pull request
Jul 13, 2021
joeyparrish
pushed a commit
that referenced
this pull request
Jul 13, 2021
Close: #3512 Backported to v3.0.x Change-Id: I20df8c4b9cf621dad75f4d981bd04571fcaf481e
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #3512