Skip to content

Thumbnail position calculation #3516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeyparrish merged 5 commits into from
Jul 9, 2021
Merged

Thumbnail position calculation #3516

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9988e7
Fix calculation for Y position of thumbnails
paulJordaan Jul 5, 2021
14d746c
Add tests
paulJordaan Jul 7, 2021
4e6e092
Add email to AUTHORS and CONTRIBUTORS
paulJordaan Jul 7, 2021
b03af10
Simplify position calculation
paulJordaan Jul 9, 2021
37ad815
Edit test to cover prevent false positive because of similar values
paulJordaan Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add email to AUTHORS and CONTRIBUTORS
  • Loading branch information
@paulJordaan
paulJordaan committed Jul 7, 2021
commit 4e6e09298070277c651876f000947d0236c21c5a
4 changes: 2 additions & 2 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,11 @@ Nick Desaulniers <nick@mozilla.com>
Oskar Arvidsson <oskar@irock.se>
Patrick Cruikshank <patrick.cruikshank@gmail.com>
Patrick Kunka <patrick@kunkalabs.com>
Paul Jordaan <pdjordaan@gmail.com>
Percy Tse <percy.tse@gmail.com>
Peter Nycander <peter.nycander@gmail.com>
Philo Inc. <*@philo.com>
Prakash <duggaraju@gmail.com>
Robert Colantuoni <rgc@colantuoni.com>
Roi Lipman <roilipman@gmail.com>
Roksolana Ivanyshyn <roksolana.ivanyshyn.pub@gmail.com>
Expand All @@ -69,6 +71,4 @@ uStudio Inc. <*@ustudio.com>
Verizon Digital Media Services <*@verizondigitalmedia.com>
Vincent Valot <valot.vince@gmail.com>
Wayne Morgan <wayne.morgan.dev@gmail.com>
Prakash <duggaraju@gmail.com>


7 changes: 4 additions & 3 deletions CONTRIBUTORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
# Please keep the list sorted.

Aaron Vaage <vaage@google.com>
Adrián Gómez Llorente <adgllorente@gmail.com>
Aidan Ridley <aidan.ridley@charter.com>
Alex Jones <alexedwardjones@gmail.com>
Alvaro Velad Galvan <alvaro.velad@mirada.tv>
Expand Down Expand Up @@ -76,8 +77,10 @@ Niklas Korz <nk@alugha.com>
Oskar Arvidsson <oskar@irock.se>
Patrick Cruikshank <patrick.cruikshank@gmail.com>
Patrick Kunka <patrick@kunkalabs.com>
Paul Jordaan <pdjordaan@gmail.com>
Percy Tse <percy.tse@gmail.com>
Peter Nycander <peter.nycander@gmail.com>
Prakash Duggaraju <duggaraju@gmail.com>
Robert Colantuoni <rgc@colantuoni.com>
Rohit Makasana <rohitbm@google.com>
Roi Lipman <roilipman@gmail.com>
Expand All @@ -104,6 +107,4 @@ Vasanth Polipelli <vasanthap@google.com>
Vignesh Venkatasubramanian <vigneshv@google.com>
Vincent Valot <valot.vince@gmail.com>
Wayne Morgan <wayne.morgan.dev@gmail.com>
Yohann Connell <robinconnell@google.com>
Adrián Gómez Llorente <adgllorente@gmail.com>
Prakash Duggaraju <duggaraju@gmail.com>
Yohann Connell <robinconnell@google.com>