fix: fix breaking captions#3556
Merged
michellezhuogg merged 4 commits intoshaka-project:masterfrom Aug 16, 2021
Merged
Conversation
bcupac
changed the title
Contributor
michellezhuogg
left a comment
michellezhuogg
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
Collaborator
|
All tests passed! |
joeyparrish
pushed a commit
that referenced
this pull request
Oct 12, 2021
joeyparrish
pushed a commit
that referenced
this pull request
Oct 12, 2021
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3555
Screenshots (optional)
Type of change
not work as expected)
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass