Deduplication of init data to reduce memory usage#3695
Merged
theodab merged 1 commit intoshaka-project:masterfrom Oct 15, 2021
Merged
Deduplication of init data to reduce memory usage#3695theodab merged 1 commit intoshaka-project:masterfrom
theodab merged 1 commit intoshaka-project:masterfrom
Conversation
theodab
approved these changes
Oct 15, 2021
Collaborator
|
All tests passed! |
Contributor
|
Thank you for your contribution! |
joeyparrish
pushed a commit
that referenced
this pull request
Jan 5, 2022
Linear streams accumulate init data over time because the init data is pushed to an array regardless of whether or not it already exists as part of the logic to combine periods. This PR dedupes the init data based on keyId to help reduce memory usage over extended playouts.
joeyparrish
pushed a commit
that referenced
this pull request
Jan 5, 2022
Linear streams accumulate init data over time because the init data is pushed to an array regardless of whether or not it already exists as part of the logic to combine periods. This PR dedupes the init data based on keyId to help reduce memory usage over extended playouts.
joeyparrish
pushed a commit
that referenced
this pull request
Jan 5, 2022
Linear streams accumulate init data over time because the init data is pushed to an array regardless of whether or not it already exists as part of the logic to combine periods. This PR dedupes the init data based on keyId to help reduce memory usage over extended playouts.
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linear streams accumulate init data over time because the init data is pushed to an array regardless of whether or not it already exists as part of the logic to combine periods. This PR will dedupe the init data based on keyId to help reduce memory usage over extended playouts.
Type of change
not work as expected)
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass