Fix #3783 captions not working after a period transition on live DASH streams#3801
Merged
joeyparrish merged 3 commits intoshaka-project:masterfrom Dec 13, 2021
Merged
Conversation
TheModMaker
reviewed
Dec 9, 2021
lib/text/text_engine.js
Outdated
| if (id == this.selectedClosedCaptionId_) { | ||
| // With multiperiod live DASH DAI streams a comma is appended to the | ||
| // selectedClosedCaptionId string each time a new period appears in | ||
| // the manifest e.g. "CC1,,," while the id value remains "CC1" |
Contributor
There was a problem hiding this comment.
That is either a bug in the caption parser or your content. I don't think this should be handled here.
Contributor
Author
There was a problem hiding this comment.
Ok found and fixed the root cause
…e DASH DAI streams.
joeyparrish
approved these changes
Dec 13, 2021
joeyparrish
pushed a commit
that referenced
this pull request
Jan 5, 2022
…streams (#3801) Embedded CEA-608 captions don't work on multi period live DASH DAI streams after new periods appear in the manifest because commas are appended the streams originalId string, which disrupts some stream matching code in text_engine.js The problem has been resolved by preventing makeTextStreamsForClosedCaptions() from altering the PeriodCombiner.textStreams_ array. Fixes #3783 Change-Id: I0b99df9cf081a5ad340ac16344f5f0240633d683
joeyparrish
pushed a commit
that referenced
this pull request
Jan 5, 2022
…streams (#3801) Embedded CEA-608 captions don't work on multi period live DASH DAI streams after new periods appear in the manifest because commas are appended the streams originalId string, which disrupts some stream matching code in text_engine.js The problem has been resolved by preventing makeTextStreamsForClosedCaptions() from altering the PeriodCombiner.textStreams_ array. Fixes #3783 Change-Id: If34ff360dee76f03badef6a5b6c89751e1986285
joeyparrish
pushed a commit
that referenced
this pull request
Jan 5, 2022
…streams (#3801) Embedded CEA-608 captions don't work on multi period live DASH DAI streams after new periods appear in the manifest because commas are appended the streams originalId string, which disrupts some stream matching code in text_engine.js The problem has been resolved by preventing makeTextStreamsForClosedCaptions() from altering the PeriodCombiner.textStreams_ array. Fixes #3783 Change-Id: I9abce3f34bf45d506325c13cb06c550d556c2d62
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3783
Embedded CEA-608 captions don't work on multi period live DASH DAI streams after new periods appear in the manifest because commas are appended the streams originalId string, which disrupts some stream matching code in text_engine.js
The problem has been resolved by preventing makeTextStreamsForClosedCaptions() from altering the PeriodCombiner.textStreams_ array.
Screenshots (optional)
NA
Type of change
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass