fix(ui): Fix exception on screen rotation if fullscreen is not supported#4669
Merged
joeyparrish merged 2 commits intoshaka-project:mainfrom Nov 9, 2022
Merged
fix(ui): Fix exception on screen rotation if fullscreen is not supported#4669joeyparrish merged 2 commits intoshaka-project:mainfrom
joeyparrish merged 2 commits intoshaka-project:mainfrom
Conversation
Contributor
|
Incremental code coverage: 0.00% |
avelad
added
type: bug
joeyparrish
approved these changes
Nov 9, 2022
joeyparrish
changed the title
joeyparrish
changed the title
joeyparrish
added a commit
that referenced
this pull request
Nov 9, 2022
…ted (#4669) If fullscreen is not supported when enableFullscreenOnRotation option is enabled, this exception occurred: TypeError: i.j.requestFullscreen is not a function. (In 'i.j.requestFullscreen({navigationUI:"hide"})', 'i.j.requestFullscreen' is undefined) This fixes the exception by checking isFullScreenSupported(). Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
joeyparrish
added a commit
that referenced
this pull request
Nov 9, 2022
…ted (#4669) If fullscreen is not supported when enableFullscreenOnRotation option is enabled, this exception occurred: TypeError: i.j.requestFullscreen is not a function. (In 'i.j.requestFullscreen({navigationUI:"hide"})', 'i.j.requestFullscreen' is undefined) This fixes the exception by checking isFullScreenSupported(). Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
joeyparrish
added a commit
that referenced
this pull request
Nov 9, 2022
…ted (#4669) If fullscreen is not supported when enableFullscreenOnRotation option is enabled, this exception occurred: TypeError: i.j.requestFullscreen is not a function. (In 'i.j.requestFullscreen({navigationUI:"hide"})', 'i.j.requestFullscreen' is undefined) This fixes the exception by checking isFullScreenSupported(). Backported to v3.2.x Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
joeyparrish
added a commit
that referenced
this pull request
Nov 9, 2022
…ted (#4669) If fullscreen is not supported when enableFullscreenOnRotation option is enabled, this exception occurred: TypeError: i.j.requestFullscreen is not a function. (In 'i.j.requestFullscreen({navigationUI:"hide"})', 'i.j.requestFullscreen' is undefined) This fixes the exception by checking isFullScreenSupported(). Backported to v3.3.x Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
joeyparrish
added a commit
that referenced
this pull request
Dec 6, 2022
This refactors and cleans up fullscreen functionality in the UI so that all triggers are consistent and work correctly on all platforms. See also #4669 Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
joeyparrish
added a commit
that referenced
this pull request
Dec 8, 2022
This refactors and cleans up fullscreen functionality in the UI so that all triggers are consistent and work correctly on all platforms. See also #4669 Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
joeyparrish
added a commit
that referenced
this pull request
Dec 8, 2022
This refactors and cleans up fullscreen functionality in the UI so that all triggers are consistent and work correctly on all platforms. See also #4669 Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Console error in environment where fullscreen is not possible when enableFullscreenOnRotation option is turned on
TypeError: i.j.requestFullscreen is not a function. (In 'i.j.requestFullscreen({navigationUI:"hide"})', 'i.j.requestFullscreen' is undefined)How to fix
check
isFullScreenSupportedononScreenRotation