Ignore offsets in VTT text tracks#599
Closed
sanbornhilland wants to merge 1 commit intoshaka-project:masterfrom
Closed
Ignore offsets in VTT text tracks#599sanbornhilland wants to merge 1 commit intoshaka-project:masterfrom
sanbornhilland wants to merge 1 commit intoshaka-project:masterfrom
Conversation
Member
|
This is blocked on discussion in #595. I'm not yet convinced that this is necessary. |
Member
|
As mentioned in #595 (comment), please change this to add either the offset or the segment time, but not both. Before we release v2.1, we will remove the flag and always use segment-relative timestamps (and never offsets). |
Member
|
@sanbornhnewyyz, I went ahead and committed a fix for this myself. Hope you don't mind. Thanks for contributing! |
Contributor
Author
|
Thanks for the hard work of investigating this. Sorry for letting it slip. |
Member
|
No worries! We are always happy to help. |
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #595