feat: add a live sync panic mode#6149
Conversation
avelad
left a comment
There was a problem hiding this comment.
Just one question, have you tested that this code works well in src=? (e.g. HLS in Safari)
Otherwise, LGTM!
|
I did not test this extensively, yet. |
|
Seems to be working. I was thinking that it wasn't kicking in enough and then I realized I needed to convert the threshold into ms. Also, when playing back live HLS in chrome, it basically always stopped here: Lines 5657 to 5661 in 35b8fb1 But otherwise, seems to be working as expected for DASH and for live hls on safari. |
For it to work in HLS Live in Chorme you need to |
Ah, Ok, I was missing something 🙂. Thanks! |
This PR introduces a live sync panic mode (
streaming.liveSyncPanicMode) which sets the player into thestreaming.liveSyncMinPlaybackRatewhile we're within thestreaming.liveSyncPanicThreshold. This should help reduce the change of subsequent rebuffering events by moving further away from the live edge.Part 1 of potentially 3 of #6131.