feat(DASH): Add MPD Chaining support#6641
Merged
avelad merged 5 commits intoshaka-project:mainfrom May 21, 2024
Merged
Conversation
avelad
added
type: enhancement
Member
Author
|
@shaka-bot test |
Collaborator
|
@avelad: Lab tests started with arguments:
|
Collaborator
|
Incremental code coverage: 91.67% |
gkatsev
approved these changes
May 20, 2024
Contributor
gkatsev
left a comment
gkatsev
left a comment
There was a problem hiding this comment.
Much quicker than expected!
Member
Author
|
@shaka-bot test |
Collaborator
|
@avelad: Lab tests started with arguments:
|
theodab
suggested changes
May 21, 2024
Contributor
theodab
left a comment
theodab
left a comment
There was a problem hiding this comment.
I wonder if it would be worth it to add an optional new UI element for this, like a "skip to next" button or something.
I guess that'd be better as a follow-up PR, if so.
theodab
approved these changes
May 21, 2024
joeyparrish
reviewed
May 22, 2024
| if (this.preloadNextUrl_ && | ||
| this.assetUri_ != this.preloadNextUrl_.getAssetUri()) { | ||
| if (!this.preloadNextUrl_.isDestroyed()) { | ||
| this.preloadNextUrl_.destroy(); |
Member
There was a problem hiding this comment.
This should be awaited, right?
|
Is there any documentation on how to use this feature?! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #3926