Skip to content

feat(UI): Add close button to statistics panel #7482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avelad merged 2 commits into from
Oct 23, 2024
+26 −1
Merged

feat(UI): Add close button to statistics panel #7482

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff18002
feat(UI): Add close button to statistics panel
avelad Oct 23, 2024
6925a70
Fix test
avelad Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test
  • Loading branch information
@avelad
avelad committed Oct 23, 2024
commit 6925a7088bfa3324a0ae2b703e28922376e2e57e
3 changes: 2 additions & 1 deletion test/ui/ui_unit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,8 @@ describe('UI', () => {
it('displays all the available statistics', () => {
const skippedStats = ['stateHistory', 'switchHistory'];
const nodes = statisticsContainer.childNodes;
let nodeIndex = 0;
// First index is close button.
let nodeIndex = 1;

for (const statistic in new shaka.util.Stats().getBlob()) {
if (!skippedStats.includes(statistic)) {
Expand Down