ci: Fix demo index workflow runs too early when a release is made#7892
Merged
avelad merged 2 commits intoshaka-project:mainfrom Jan 16, 2025
Merged
ci: Fix demo index workflow runs too early when a release is made#7892avelad merged 2 commits intoshaka-project:mainfrom
avelad merged 2 commits intoshaka-project:mainfrom
Conversation
avelad
added
type: bug
Collaborator
|
Incremental code coverage: No instrumented code was changed. |
tykus160
approved these changes
Jan 16, 2025
joeyparrish
reviewed
Jan 16, 2025
| update-demo-index: | ||
| name: Deploy Demo Version Index | ||
| needs: [appspot] | ||
| uses: ./.github/workflows/demo-version-index.yaml |
Member
There was a problem hiding this comment.
I might be misremembering, but don't we need a specific trigger for this in the target workflow?
Member
Author
There was a problem hiding this comment.
It is not necessary, because we are using needs, so we wait for all the appspot tasks to finish before running this one.
Member
There was a problem hiding this comment.
I understand "needs", but I meant something else. I looked it up, and we need the workflow_call trigger on demo-version-index.yaml to use it this way. This differs from workflow_dispatch, which we already have for manual triggering.
joeyparrish
reviewed
Jan 16, 2025
| types: [published] | ||
| # NOTE: So long as releases are made without a personal access token (PAT), | ||
| # they will not activate this workflow's release trigger. For now, the | ||
| # schedule trigger will compensate for that by updating the index nightly. |
Member
There was a problem hiding this comment.
Could we drop the schedule trigger now?
joeyparrish
added a commit
that referenced
this pull request
Jan 16, 2025
The `workflow_call` trigger is required to allow calling a workflow from another with "uses:". The `schedule` trigger was always a workaround, and should now be removed. See also PR #7892.
avelad
added a commit
that referenced
this pull request
Jan 17, 2025
avelad
pushed a commit
that referenced
this pull request
Jan 17, 2025
The `workflow_call` trigger is required to allow calling a workflow from another with "uses:". The `schedule` trigger was always a workaround, and should now be removed. See also PR #7892.
avelad
added a commit
that referenced
this pull request
Jan 17, 2025
avelad
pushed a commit
that referenced
this pull request
Jan 17, 2025
The `workflow_call` trigger is required to allow calling a workflow from another with "uses:". The `schedule` trigger was always a workaround, and should now be removed. See also PR #7892.
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this pull request
Jan 17, 2025
joeyparrish
added a commit
that referenced
this pull request
Jan 17, 2025
avelad
pushed a commit
that referenced
this pull request
Jan 23, 2025
avelad
pushed a commit
that referenced
this pull request
Jan 23, 2025
joeyparrish
pushed a commit
that referenced
this pull request
Feb 22, 2025
joeyparrish
added a commit
that referenced
this pull request
Feb 22, 2025
The `workflow_call` trigger is required to allow calling a workflow from another with "uses:". The `schedule` trigger was always a workaround, and should now be removed. See also PR #7892.
joeyparrish
added a commit
that referenced
this pull request
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7379