Skip to content

perf: Only set the timers on UITextDisplayer when there are cues#8114

Merged
avelad merged 1 commit intoshaka-project:mainfrom
avelad:perf-UITextDisplayer
Feb 19, 2025
Merged

perf: Only set the timers on UITextDisplayer when there are cues#8114
avelad merged 1 commit intoshaka-project:mainfrom
avelad:perf-UITextDisplayer

Conversation

@avelad
Copy link
Member

@avelad avelad commented Feb 19, 2025

No description provided.

@avelad avelad added type: performance A performance issue component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release labels Feb 19, 2025
@avelad avelad added this to the v4.14 milestone Feb 19, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit f310833 into shaka-project:main Feb 19, 2025
22 of 23 checks passed
@avelad avelad deleted the perf-UITextDisplayer branch February 19, 2025 12:34
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 20, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Apr 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: performance A performance issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants