Skip to content

Added 'noSort' option to disable sorting.#2

Merged
shannonmoeller merged 1 commit intoshannonmoeller:masterfrom
Kreozot:noSort_option
Feb 7, 2017
Merged

Added 'noSort' option to disable sorting.#2
shannonmoeller merged 1 commit intoshannonmoeller:masterfrom
Kreozot:noSort_option

Conversation

@Kreozot
Copy link
Contributor

@Kreozot Kreozot commented Jan 11, 2017

No description provided.

@coveralls
Copy link

coveralls commented Jan 11, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e25ac56 on Kreozot:noSort_option into c0180db on shannonmoeller:master.

@shannonmoeller
Copy link
Owner

lgtm. Merging. Will release when I'm back at a terminal.

Thanks for the PR! Sorry for the slow response.

@shannonmoeller shannonmoeller merged commit 607e755 into shannonmoeller:master Feb 7, 2017
@shannonmoeller
Copy link
Owner

shannonmoeller commented Feb 7, 2017

I made a slight modification to this. I renamed the noSort option to sort with a default true value. So to disable sorting you pass sort: false now:

columns(['foo', 'bar'], { sort: false });

Published as v1.1.0.

@Kreozot
Copy link
Contributor Author

Kreozot commented Feb 7, 2017

@shannonmoeller Draw you attention that you forgot to change this option in readme.md

@shannonmoeller
Copy link
Owner

Well that's just embarrassing. Thanks.

@shannonmoeller
Copy link
Owner

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants