chore: upgrade garmin fit sdk profile version 21.212.0 - #61
Conversation
Bump SDK_VERSION and regenerate profile code from Garmin fit-sdk-tools Profile.xlsx 21.212.0. Additive delta: wheelchair_pushing activity type, manufacturer/product enums, session total_reps/total_pushes and monitoring pushes fields. Update version pins in tests/docs and towncrier fragment. Fixes #60 Co-authored-by: multica-agent <github@multica.ai>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3dd5ffa48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| field = self.get_field(SessionTotalCyclesField.ID) | ||
| type_field = self.get_field(SessionSubSportField.ID) | ||
|
|
||
| is_sub_field_valid = type_field and type_field.get_value() in [20] |
There was a problem hiding this comment.
For files where sub_sport is STRENGTH_TRAINING but sport is not HIIT, this guard still exposes field 10 as total_reps; the new subfield's reference map requires both SessionSubSportField.ID: [20] and SessionSportField.ID: [62], and get_valid_sub_field() can then select a different subfield such as total_strokes while the property returns the value as reps. Because this is generated code, the fix should be made in the generator/template and regenerated rather than patched directly.
AGENTS.md reference: AGENTS.md:L53-L58
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 92.72% 92.72%
=======================================
Files 36 36
Lines 2721 2721
Branches 461 461
=======================================
Hits 2523 2523
Misses 117 117
Partials 81 81 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
Summary
Upgrade the bundled Garmin FIT Profile from 21.205.0 to 21.212.0 (GitHub #60).
Profile delta (21.205.0 → 21.212.0)
Types (enum value adds)
activity_type+wheelchair_pushinggarmin_product+cirqa_smart_band,fenix7_pro_solar_no_wifimanufacturer+una_watchMessages
monitoring+pushessession+total_pushes,total_repsNo new/removed messages; sheet layout unchanged.
Changes
fit_tool/gen/Profile_21.205.0.xlsxwithProfile_21.212.0.xlsx(from fit-sdk-tools 21.212.0)SDK_VERSION = '21.212.0'fit_tool/profile/**viauv run gen-profilenews/60.depTest plan
uv run gen-profileuv run pytest -q— 440 passed, 1 skipped (live JS interop needsFIT_JS_SDK_PATH+ Node)uv run ruff check fit_toolFixes #60