forked from apache/cloudstack
-
Notifications
You must be signed in to change notification settings - Fork 7
Retrieve diagnostics (for review purpose) #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
DaanHoogland
wants to merge
72
commits into
shapeblue:master
from
charles-phiri:retrieve-diagnostics
Closed
Changes from 1 commit
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
1ee9980
Initial commit
charles-phiri 9f7eff1
some code to enhance the configure method in the Service Layer
charles-phiri 987534e
refactored Service interface
charles-phiri 4ef4c2f
refactored Service interface
charles-phiri 6256e91
refactored Service interface
charles-phiri c7e5572
refactored Service interface
charles-phiri 74822ce
refactored Service interface
charles-phiri e017c1c
refactored Service interface
charles-phiri 9438236
refactored Service interface
charles-phiri 99bb448
refactored Service interface
charles-phiri 3cdb059
refactored Service interface
charles-phiri be2d1b3
refactored Service interface
charles-phiri 6c76aa9
refactored Service interface
charles-phiri 1e24faa
refactored Service interface
charles-phiri ee7907c
refactored Service interface
charles-phiri 65b7d38
refactored Service interface
charles-phiri 182dea9
Removed unused imports
charles-phiri 395b246
refactored Service interface
charles-phiri aae408c
refactored Service interface
charles-phiri a4c6d5d
This is a compiled version of the work I have been doing so far. I am…
charles-phiri e8aa68b
Changed the schema script which was having errors when deploying the DB.
charles-phiri a10c798
Minor fixes on SQL schema file
charles-phiri e0292b5
Changed the schema script which was having errors when deploying the DB.
charles-phiri 64a6185
Refactored some code in the API (Cmd) class.
charles-phiri 135383d
Added some more functionality in the Service Layer class.
charles-phiri 2be2e9d
Removed the code that was using generics in the class DiagnosticsKey.
charles-phiri 943626e
Corrected code in my DiagnosticsConfigDepotImpl class that was using …
charles-phiri e187bc1
Corrected code in my RetrieveDiagnosticsVO class that was using the g…
charles-phiri 98e2aa5
Yet still, removed some code using generics code.
charles-phiri 3b97954
Added more code in the Service Layer class and refactored code in the…
charles-phiri 987b6f7
Refactored code in Service Impl class.
charles-phiri 2ff8287
Added code in spring xml file.
charles-phiri 351f721
Created my own interface class for DiagnosticsConfigDepotImpl as I co…
charles-phiri 94a2fb5
Changed most of the code in the DaO and VO classes including its usag…
charles-phiri 8b57ee6
Refactored code in the Dao and VO, and also added one more method to …
charles-phiri 8995e4f
Cleaned up the code and refactored code so that it has some of the ch…
charles-phiri e6c1029
Refactored code in the Service Layer impl.
charles-phiri 974de4a
Made some code logic changes to the Service Layer when populating the…
charles-phiri fc5ef6f
Addressed comments on the code.
charles-phiri ca4dd82
Refactored code in the Service Layer for retrieving recodes from the …
charles-phiri ca5c308
Added unit test file to test the functionality in the Service Layer i…
charles-phiri fa129fa
Added unit test file to test the functionality in the Service Layer i…
charles-phiri e97895f
Removed the duplicated licence information.
charles-phiri f525aa9
1. Cleaned up code as per Daan's comments.
charles-phiri 3e62161
Mgt-server could be running in a vm that does not have diskOffering. …
charles-phiri cc880d4
Added code to check capacity of the disk space and compare it to the …
charles-phiri 91514d4
Added code to check capacity of the disk space and compare it to the …
charles-phiri 141ab51
Added code to check capacity of the disk space and compare it to the …
charles-phiri 2e55ec2
Added code to check capacity of the disk space and compare it to the …
charles-phiri d2b2d62
Added code to check capacity of the disk space and compare it to the …
charles-phiri 45bd812
Added code to parse for a default value which is in square brackets, …
charles-phiri c9d7ad2
Inserted getters/setters for the script filename variables
charles-phiri dd5579d
Added skeleton scripts (still adding code) to retrieve files and run …
charles-phiri 46098bc
Added code for the two command classes (ExecuteScriptCommand and Retr…
charles-phiri 5d22c03
Added code for the two command classes (ExecuteScriptCommand and Retr…
charles-phiri 5086e34
Added code for the two command classes (ExecuteScriptCommand and Retr…
charles-phiri 555cc86
Add method to check disk space
charles-phiri 94b414d
Minor changes in unit test
charles-phiri 0f19d46
Still working on unit test
charles-phiri 956a434
Added more unit tests.
charles-phiri 76e5545
Skeleton implementation of the Garbage Collector.
charles-phiri c458261
Refactored code while testing, mostly in the Service Layer. Added a c…
charles-phiri 9a6c5cf
Got rid of the cyclic dependencies that I was encountering when compi…
charles-phiri 24f123a
Merge branch 'master' of https://github.com/apache/cloudstack into re…
charles-phiri f66c840
Refactored code in the Service Layer and the python scripts for retri…
charles-phiri 1e4a426
Marvin tests for the RetrieveDiagnostics API
charles-phiri 63f6b9b
Full complete code after refactoring. Addition of copyFileFromSystemV…
charles-phiri 3acbfe4
Code cleanup and refactoring
charles-phiri d08cc7b
Complete RerieveDiagnostics API implementation for testing.
charles-phiri 3c12e07
Complete RerieveDiagnostics API .
charles-phiri f88bde0
Minor bug fixes.
charles-phiri 720da4c
Code for the RetrieveDiagnostics API.
charles-phiri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Got rid of the cyclic dependencies that I was encountering when compi…
…ling after the implementation of the RetrieveDiagnostics API Garbage Collector - DiagnosticsGarbageCollector
- Loading branch information
commit 9a6c5cf779db93ca2853653bd6fddd8122ee39cd
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
api/src/main/java/org/apache/cloudstack/diagnostics/DeleteZipCommand.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package org.apache.cloudstack.diagnostics; | ||
|
|
||
| import com.cloud.agent.api.Command; | ||
| import com.cloud.agent.api.to.DataStoreTO; | ||
|
|
||
| public class DeleteZipCommand extends Command { | ||
| private String zipFile; | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe name it zipFileName? |
||
| private DataStoreTO destStore; | ||
|
|
||
| public DeleteZipCommand(String zipFile, DataStoreTO destStore) { | ||
| this.zipFile = zipFile; | ||
| this.destStore = destStore; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean executeInSequence() { | ||
| return false; | ||
| } | ||
|
|
||
| public DataStoreTO getDestStore() { | ||
| return destStore; | ||
| } | ||
|
|
||
| public String getZipFile() { | ||
| return zipFile; | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it is not custm in cloudstack but can you add some documentation?
i.e: