Skip to content

Conversation

@NeOMakinG
Copy link
Collaborator

@NeOMakinG NeOMakinG commented Nov 20, 2025

Description

Extracting gridplus sdk as it's quite big to its own chunk, so we can deploy the app without worrying we have a bundle bigger than 29mb

Issue (if applicable)

Nothing, private conv

Risk

Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

deployed to neo for testing purposes https://github.com/shapeshift/web/actions/runs/19537361206

But you can also use yarn build:web and verify that the main bundle is under 29mb

And test that gridplus does work!

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

image

Gridplus is working as expected

Summary by CodeRabbit

  • Chores
    • Updated build bundling strategy to optimize module loading.
    • Enhanced source map generation configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@NeOMakinG NeOMakinG requested a review from a team as a code owner November 20, 2025 13:21
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

📝 Walkthrough

Walkthrough

The change modifies vite.config.mts to add a dedicated chunk for the gridplus-sdk module and adjusts sourcemap generation logic. In non-DEPLOY development mode, sourcemaps remain inline; otherwise they are enabled by default instead of being disabled.

Changes

Cohort / File(s) Summary
Build configuration updates
vite.config.mts
Added gridplus-sdk chunking rule for node_modules and modified sourcemap generation behavior to enable sourcemaps by default in non-development or DEPLOY scenarios instead of disabling them.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Single file modification with straightforward build configuration changes
  • Two discrete, non-overlapping logic updates that are easy to verify
  • Standard Vite configuration patterns with clear intent

Possibly related PRs

  • fix: bundle size limit #10263: Modifies the same manualChunks configuration in vite.config.mts with additional SDK-specific chunk rules, indicating ongoing refinement of module chunking strategy.

Suggested reviewers

  • premiumjibles

Poem

🐰 A bundle optimized, neat and tight,
Gridplus-SDK now chunks just right,
Sourcemaps glow where shadows hide,
Build speeds soar with bundled pride! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main objective of the PR: extracting the GridPlus SDK into a dedicated chunk to reduce main bundle size, which aligns with the primary change in the vite.config.mts file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sourcemap-chunks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gm

Image

@gomesalexandre gomesalexandre merged commit 38f3eab into develop Nov 21, 2025
4 checks passed
@gomesalexandre gomesalexandre deleted the sourcemap-chunks branch November 21, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants