-
Notifications
You must be signed in to change notification settings - Fork 198
chore: extract cetus + mysten from build #11280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughExtended Vite's manual chunking configuration to assign Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (4)📓 Common learnings📚 Learning: 2025-08-12T17:52:34.672ZApplied to files:
📚 Learning: 2025-08-12T17:53:56.322ZApplied to files:
📚 Learning: 2025-08-29T18:09:45.982ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gomesalexandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deployed on gome to confirm Cloudflare action is happy, but pre-stamping!
gomesalexandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xApotheosis doesn't hurt getting this one in as a first build size improvement, but looks like we may need to extract more:
|
Indeed, more to do @gomesalexandre! ty, I'll merge this and then take another pass. |
| if (id.includes('@cetusprotocol')) return '@cetusprotocol' | ||
| if (id.includes('@mysten')) return '@mysten' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xApotheosis Brain stopping to brain for tonight but if we want to give a try to this, took a look at recent additions (re: yarn.lock diff) and looks like:
- valibot version change brought by mysten added 1.74Mb
@0noco/graphqllspbrought by mysten added 1.46Mbgraphqlbrought by mysten added something similar to the above
Few others but actually smol diff
Obviously once web is built those Mb numbers are very different and we're really looking at the size of the main .js file in the build, but gut feel is tackling either valibot alone and/or the gql tooling packages may be the goer!
Description
Fix CI by extracting
@cetusprotocoland `@mysten' packages.Issue (if applicable)
Unblocks release.
Risk
Low - if CI is green we are good.
None
Testing
Engineering
CI should now be green.
Operations
Screenshots (if applicable)
N/A
Note
Update Vite manual chunking to extract @CetusProtocol and @Mysten into separate bundles.
rollupOptions.output.manualChunksto split vendor chunks:@cetusprotocol->@cetusprotocol@mysten->@mystenWritten by Cursor Bugbot for commit 77df6b4. This will update automatically on new commits. Configure here.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.