fix: implement proper TRON getTransaction and fix Sun.io status checking

[gomesalexandre]

Description

Currently getTransaction() in TRON unchained-client returns dummy zero'd out values for blockHeight, timestamp, confirmations, and fee. This PR properly implements it by fetching both transaction data and transaction info, then uses it in Sun.io swapper for accurate status checking.

Issue (if applicable)

closes #11278

Risk

High Risk PRs Require 2 approvals

Low-medium risk. Changes affect TRON transaction status checking only. Sun.io swapper now waits for actual on-chain confirmation before marking swaps complete.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

TRON (Sun.io swapper), TRON transaction status polling

Testing

Engineering

• Perform Sun.io swaps (TRX ↔ TRC-20)
• Balance updates should be significantly more reliable (no more stale balances)
• Transactions should confirm slightly slower (waits for actual block confirmation instead of mempool success)

⚠️ NOTE: This is not a silver bullet. We may want to increase the number of confirmations we wait for before considering a transaction complete, but for now this should fix most balance update issues. If needed, that would be a simple one-character change to adjust the confirmation threshold.

Operations

• 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Sun.io is already behind the VITE_FEATURE_SUN_IO_SWAP feature flag.

Screenshots (if applicable)

https://jam.dev/c/6db62ace-80e4-4766-83db-6d5455f02b18

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Improved transaction confirmation detection to require blockchain confirmations before marking transactions as confirmed
  • Enhanced transaction fee information retrieval for better accuracy
  • Refined transaction status handling with clearer Pending and Failed state determination

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request implements proper TRON transaction fetching in the unchained-client by querying both transaction and transaction info endpoints in parallel, enriching TronTx with blockHeight, timestamp, confirmations, and fee data. The Sunico swapper is updated to use the new adapter method with a confirmations guard for status determination. An SVG asset import is also adjusted to use module syntax instead of URL query.

Changes

Cohort / File(s)	Summary
TRON API Implementation packages/unchained-client/src/tron/api.ts, packages/unchained-client/src/tron/types.ts	Implements getTransaction() to fetch both wallet/gettransactionbyid and wallet/gettransactioninfobyid endpoints in parallel. Extracts blockNumber, blockTimeStamp, and fee from info response and populates TronTx fields (blockHeight, timestamp, confirmations, fee). Adds optional ret property to TronTx interface with contractRet and fee structure.
Sunico Swapper Update packages/swapper/src/swappers/SunioSwapper/endpoints.ts	Replaces REST-based transaction fetch with direct adapter.httpProvider.getTransaction({ txid }). Adds requirement for tx.confirmations > 0 to mark status as Confirmed; retains contractRet === 'REVERT' mapping to Failed and adds Pending as fallback. Removes prior network error handling.
Asset Import Adjustment src/pages/SplashScreen/SplashScreen.tsx	Changes SVG asset import from URL query syntax (?url) to direct module import, altering asset resolution at runtime without modifying logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Areas requiring extra attention:

• Parallel endpoint fetch logic in packages/unchained-client/src/tron/api.ts: Verify Promise.all usage and fallback handling when info response is unavailable; confirm default values (0/0/'0') are appropriate across all code paths.
• Confirmations guard in packages/swapper/src/swappers/SunioSwapper/endpoints.ts: Validate that the new tx.confirmations > 0 requirement correctly identifies confirmed vs. pending transactions and doesn't introduce regressions in status detection.
• TronTx type extension in packages/unchained-client/src/tron/types.ts: Check that the new optional ret field is properly consumed by dependent code and doesn't conflict with existing parsing logic.

Possibly related PRs

• feat: sun.io swapper #11261: Directly modifies the same Sun.io swapper file and checkTradeStatus logic being updated with the new confirmations guard.
• feat: wire-up hdwallet-ledger with tron support bits #11245: Modifies the same Tron unchained-client files (api.ts, types.ts) for transaction handling and type updates.
• fix: orbs svg import killing local #11070: Modifies the same SplashScreen SVG asset import in reverse (URL query vs. module import).

Suggested reviewers

• NeOMakinG

Poem

🐰 Two endpoints, fetched as one,
TRON's transactions, now properly run,
Confirmations counted, fees now in sight,
The swapper hops forward—everything's right! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	SVG import change in SplashScreen.tsx appears unrelated to TRON getTransaction or Sun.io swapper objectives and lacks clear justification.	Clarify or remove the SplashScreen.tsx SVG import modification, or move it to a separate PR focused on asset import refactoring.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	Title clearly identifies the main changes: implementing proper TRON getTransaction and fixing Sun.io status checking, which directly reflect the PR's core objectives.
Linked Issues check	✅ Passed	PR implements proper getTransaction() in tron unchained-client api.ts with real transaction data [#11278], and refactors Sun.io swapper to use proper status checking [#11278].
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix_tron_getTransaction

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• TRC-20: Entity not found: Issue - Could not find referenced Issue.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/unchained-client/src/tron/api.ts (1)

118-161: Excellent improvement! Transaction data now includes real block and fee information.

The parallel fetch implementation efficiently retrieves both transaction data and transaction info, properly populating blockHeight, timestamp, confirmations, and fee. The graceful handling of info response failures with sensible defaults (0, '0') ensures robustness.

The simplified confirmations model (blockNumber > 0 ? 1 : 0) works well for the current use case where the swapper checks confirmations > 0 to determine if a transaction is confirmed. However, note that this represents a binary "in-block or not" rather than the actual confirmation count.

Optional future enhancement: To provide true confirmation counts, consider calculating confirmations as currentBlockHeight - blockNumber + 1 when blockNumber > 0. This would require fetching the current block height:

let confirmations = 0
if (blockNumber > 0) {
  const currentBlock = await this.getBlock({ height: -1 }) // or similar API to get latest
  if (currentBlock?.block_header?.raw_data?.number) {
    confirmations = currentBlock.block_header.raw_data.number - blockNumber + 1
  } else {
    confirmations = 1 // fallback to current behavior
  }
}

This enhancement can be deferred if the current binary model meets product requirements.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6f6b9cd and 6d59044.

📒 Files selected for processing (4)

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts (1 hunks)
• packages/unchained-client/src/tron/api.ts (1 hunks)
• packages/unchained-client/src/tron/types.ts (1 hunks)
• src/pages/SplashScreen/SplashScreen.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (11)

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,js,jsx}: Never assume a library is available - always check imports/package.json first
Prefer composition over inheritance
Write self-documenting code with clear variable and function names
Keep functions small and focused on a single responsibility
Avoid deep nesting - use early returns instead
Prefer procedural and easy to understand code
Never expose, log, or commit secrets, API keys, or credentials
Validate all inputs, especially user inputs
Handle errors gracefully with meaningful messages
Don't silently catch and ignore exceptions
Log errors appropriately for debugging
Provide fallback behavior when possible
Use appropriate data structures for the task
Never add code comments unless explicitly requested
When modifying code, do not add comments that reference previous implementations or explain what changed. Comments should only describe the current logic and functionality.
Use meaningful names for branches, variables, and functions
Always run yarn lint --fix and yarn type-check after making changes
Avoid let variable assignments - prefer const with inline IIFE switch statements or extract to functions for conditional logic

Files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts
• packages/unchained-client/src/tron/types.ts
• packages/unchained-client/src/tron/api.ts
• src/pages/SplashScreen/SplashScreen.tsx

**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Avoid useEffect where practical - use it only when necessary and following best practices
Avoid 'any' types - use specific type annotations instead
For default values with user overrides, use computed values (useMemo) instead of useEffect - pattern: userSelected ?? smartDefault ?? fallback
When function parameters are unused due to interface requirements, refactor the interface or implementation to remove them rather than prefixing with underscore
Sanitize data before displaying to prevent XSS
Memoize aggressively - wrap component variables in useMemo and callbacks in useCallback where possible
For static JSX icon elements (e.g., <TbCopy />) that don't depend on state/props, define them as constants outside the component to avoid re-renders instead of using useMemo
Account for light/dark mode using useColorModeValue hook
Account for responsive mobile designs in all UI components
When applying styles, use the existing standards and conventions of the codebase
Use Chakra UI components and conventions
All copy/text must use translation keys - never hardcode strings
Use the translation hook: useTranslate() from react-polyglot
Use useFeatureFlag('FlagName') hook to access feature flag values in components
Prefer type over interface for type definitions
Use strict typing - avoid any
Use Nominal types for domain identifiers (e.g., WalletId, AccountId)
Import types from @shapeshiftoss/caip for chain/account/asset IDs
Use useAppSelector for Redux state
Use useAppDispatch for Redux actions
Memoize expensive computations with useMemo
Memoize callbacks with useCallback

**/*.{ts,tsx}: Use Result<T, E> pattern for error handling in swappers and APIs; ALWAYS use Ok() and Err() from @sniptt/monads; AVOID throwing within swapper API implementations
ALWAYS use custom error classes from @shapeshiftoss/errors with meaningful error codes for internationalization and relevant details in error objects
ALWAYS wrap async op...

Files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts
• packages/unchained-client/src/tron/types.ts
• packages/unchained-client/src/tron/api.ts
• src/pages/SplashScreen/SplashScreen.tsx

**/swapper{s,}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/error-handling.mdc)

ALWAYS use makeSwapErrorRight for swapper errors with TradeQuoteError enum for error codes and provide detailed error information

Files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/naming-conventions.mdc)

**/*.{js,jsx,ts,tsx}: Use camelCase for variables, functions, and methods with descriptive names that explain the purpose
Use verb prefixes for functions that perform actions (e.g., fetch, validate, execute, update, calculate)
Use UPPER_SNAKE_CASE for constants and configuration values with descriptive names
Use handle prefix for event handlers with descriptive names in camelCase
Use descriptive boolean variable names with is, has, can, should prefixes
Use named exports for components, functions, and utilities instead of default exports
Use descriptive import names and avoid renaming imports unless necessary
Avoid non-descriptive variable names like data, item, obj, and single-letter variable names except in loops
Avoid abbreviations in names unless they are widely understood
Avoid generic function names like fn, func, or callback

Files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts
• packages/unchained-client/src/tron/types.ts
• packages/unchained-client/src/tron/api.ts
• src/pages/SplashScreen/SplashScreen.tsx

packages/swapper/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/swapper.mdc)

packages/swapper/**/*.ts: Use TypeScript with explicit types (e.g., SupportedChainIds) for all code in the Swapper system
Use camelCase for variable and function names in the Swapper system
Use PascalCase for types, interfaces, and enums in the Swapper system
Use kebab-case for filenames in the Swapper system

Files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

packages/swapper/src/swappers/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/swapper.mdc)

packages/swapper/src/swappers/**/*.ts: Adhere to the Swapper directory structure: each swapper resides in packages/swapper/src/swappers// with required files (SwapperName.ts, endpoints.ts, types.ts, utils/constants.ts, utils/helpers.ts)
Validate inputs and log errors for debugging in Swapper system implementations
Swapper files must be located in packages/swapper/src/swappers/ directory structure and not placed outside this location
Avoid side effects in swap logic; ensure swap methods are deterministic and stateless

Files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

packages/swapper/src/swappers/*/*.ts

📄 CodeRabbit inference engine (.cursor/rules/swapper.mdc)

packages/swapper/src/swappers/*/*.ts: All swappers must implement the Swapper interface from packages/swapper/src/types.ts
Implement filterAssetIdsBySellable method to filter assets by supported chain IDs in the sell property
Implement filterBuyAssetsBySellAssetId method to filter assets by supported chain IDs in the buy property
Reuse executeEvmTransaction utility for EVM-based swappers instead of implementing custom transaction execution

Files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

packages/swapper/src/swappers/*/endpoints.ts

📄 CodeRabbit inference engine (.cursor/rules/swapper.mdc)

packages/swapper/src/swappers/*/endpoints.ts: All swapper API implementations must implement the SwapperApi interface from packages/swapper/src/types.ts
Reuse checkEvmSwapStatus utility for checking EVM swap status instead of implementing custom status checks

Files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

**/*.{tsx,jsx}

📄 CodeRabbit inference engine (.cursor/rules/error-handling.mdc)

**/*.{tsx,jsx}: ALWAYS wrap React components in error boundaries and provide user-friendly fallback components with error logging
ALWAYS use useErrorToast hook for displaying errors with translated error messages and handle different error types appropriately

Use PascalCase for React component names and match the component name to the file name

Files:

• src/pages/SplashScreen/SplashScreen.tsx

**/*.{jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/react-best-practices.mdc)

**/*.{jsx,tsx}: ALWAYS use useMemo for expensive computations, object/array creations, and filtered data
ALWAYS use useMemo for derived values and computed properties
ALWAYS use useMemo for conditional values and simple transformations
ALWAYS use useCallback for event handlers and functions passed as props
ALWAYS use useCallback for any function that could be passed as a prop or dependency
ALWAYS include all dependencies in useEffect, useMemo, useCallback dependency arrays
NEVER use // eslint-disable-next-line react-hooks/exhaustive-deps unless absolutely necessary, and ALWAYS explain why dependencies are excluded if using eslint disable
ALWAYS use named exports for components; NEVER use default exports for components
KEEP component files under 200 lines when possible; BREAK DOWN large components into smaller, reusable pieces
EXTRACT complex logic into custom hooks
ALWAYS wrap components in error boundaries for production
ALWAYS handle async errors properly in async operations
ALWAYS provide user-friendly error messages in error handling
ALWAYS use virtualization for lists with 100+ items
ALWAYS implement proper key props for list items
ALWAYS lazy load heavy components using React.lazy for code splitting
ALWAYS use Suspense wrapper for lazy loaded components
USE local state for component-level state; LIFT state up when needed across multiple components; USE Context for avoiding prop drilling; USE Redux only for global state shared across multiple places
Wrap components receiving props with memo for performance optimization

Files:

• src/pages/SplashScreen/SplashScreen.tsx

**/*.tsx

📄 CodeRabbit inference engine (.cursor/rules/react-best-practices.mdc)

Ensure TypeScript types are explicit and proper; avoid use of any type

Files:

• src/pages/SplashScreen/SplashScreen.tsx

🧠 Learnings (14)

📓 Common learnings

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 11261
File: src/components/MultiHopTrade/components/TradeConfirm/hooks/useAllowanceApproval.tsx:117-172
Timestamp: 2025-12-03T23:16:28.342Z
Learning: In TRON transaction confirmation polling (e.g., approval flows in useAllowanceApproval.tsx), gomesalexandre is comfortable with optimistic completion when polling times out after the configured duration (e.g., 60 seconds). He considers the timeout a "paranoia" safety net for unlikely scenarios, expecting normal transactions to complete much faster. He prefers to defer more sophisticated timeout/failure handling as a separate follow-up concern rather than expanding PR scope.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 11170
File: patches/@shapeshiftoss+bitcoinjs-lib+7.0.0-shapeshift.0.patch:9-19
Timestamp: 2025-11-25T21:43:10.838Z
Learning: In shapeshift/web, gomesalexandre will not expand PR scope to fix latent bugs in unused API surface (like bitcoinjs-lib patch validation methods) when comprehensive testing proves the actual used code paths work correctly, preferring to avoid costly hdwallet/web verdaccio publish cycles and full regression testing for conceptual issues with zero runtime impact.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 11281
File: packages/swapper/src/swappers/PortalsSwapper/utils/fetchSquidStatus.ts:98-106
Timestamp: 2025-12-04T11:05:01.112Z
Learning: In packages/swapper/src/swappers/PortalsSwapper/utils/fetchSquidStatus.ts, getSquidTrackingLink should return blockchain explorer links (using Asset.explorerTxLink) rather than API endpoints. For non-GMP Squid swaps: return source chain explorer link with sourceTxHash when pending/failed, and destination chain explorer link with destinationTxHash when confirmed.

Learnt from: CR
Repo: shapeshift/web PR: 0
File: .cursor/rules/swapper.mdc:0-0
Timestamp: 2025-11-24T21:20:57.909Z
Learning: Applies to packages/swapper/src/swappers/*/*.ts : Reuse executeEvmTransaction utility for EVM-based swappers instead of implementing custom transaction execution

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10206
File: src/config.ts:127-128
Timestamp: 2025-08-07T11:20:44.614Z
Learning: gomesalexandre prefers required environment variables without default values in the config file (src/config.ts). They want explicit configuration and fail-fast behavior when environment variables are missing, rather than having fallback defaults.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10461
File: src/plugins/walletConnectToDapps/components/modals/ContractInteractionBreakdown.tsx:0-0
Timestamp: 2025-09-13T16:45:18.813Z
Learning: gomesalexandre prefers aggressively deleting unused/obsolete code files ("ramboing") rather than fixing technical issues in code that won't be used, demonstrating his preference for keeping codebases clean and PR scope focused.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10458
File: src/plugins/walletConnectToDapps/types.ts:7-7
Timestamp: 2025-09-10T15:34:29.604Z
Learning: gomesalexandre is comfortable relying on transitive dependencies (like abitype through ethers/viem) rather than explicitly declaring them in package.json, preferring to avoid package.json bloat when the transitive dependency approach works reliably in practice.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10503
File: .env:56-56
Timestamp: 2025-09-16T13:17:02.938Z
Learning: gomesalexandre prefers to enable feature flags globally in the base .env file when the intent is to activate features everywhere, even when there are known issues like crashes, demonstrating his preference for intentional global feature rollouts over cautious per-environment enablement.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10249
File: src/pages/ThorChainLP/components/ReusableLpStatus/TransactionRow.tsx:447-503
Timestamp: 2025-08-13T17:07:10.763Z
Learning: gomesalexandre prefers relying on TypeScript's type system for validation rather than adding defensive runtime null checks when types are properly defined. They favor a TypeScript-first approach over defensive programming with runtime validations.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10276
File: src/hooks/useActionCenterSubscribers/useThorchainLpDepositActionSubscriber.tsx:61-66
Timestamp: 2025-08-14T17:51:47.556Z
Learning: gomesalexandre is not concerned about structured logging and prefers to keep console.error usage as-is rather than implementing structured logging patterns, even when project guidelines suggest otherwise.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10413
File: src/components/Modals/FiatRamps/fiatRampProviders/onramper/utils.ts:29-55
Timestamp: 2025-09-02T14:26:19.028Z
Learning: gomesalexandre prefers to keep preparatory/reference code simple until it's actively consumed, rather than implementing comprehensive error handling, validation, and robustness improvements upfront. They prefer to add these improvements when the code is actually being used in production.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10276
File: src/pages/ThorChainLP/components/ReusableLpStatus/TransactionRow.tsx:396-402
Timestamp: 2025-08-14T17:55:57.490Z
Learning: gomesalexandre is comfortable with functions/variables that return undefined or true (tri-state) when only the truthy case matters, preferring to rely on JavaScript's truthy/falsy behavior rather than explicitly returning boolean values.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10783
File: src/context/ModalStackProvider/useModalRegistration.ts:30-41
Timestamp: 2025-10-16T11:14:40.657Z
Learning: gomesalexandre prefers to add lint rules (like typescript-eslint/strict-boolean-expressions for truthiness checks on numbers) to catch common issues project-wide rather than relying on code review to catch them.

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 10206
File: src/lib/moralis.ts:47-85
Timestamp: 2025-08-07T11:22:16.983Z
Learning: gomesalexandre prefers console.error over structured logging for Moralis API integration debugging, as they find it more conventional and prefer to examine XHR requests directly rather than rely on structured logs for troubleshooting.

📚 Learning: 2025-11-24T21:20:57.909Z

Learnt from: CR
Repo: shapeshift/web PR: 0
File: .cursor/rules/swapper.mdc:0-0
Timestamp: 2025-11-24T21:20:57.909Z
Learning: Applies to packages/swapper/src/swappers/*/endpoints.ts : Reuse checkEvmSwapStatus utility for checking EVM swap status instead of implementing custom status checks

Applied to files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

📚 Learning: 2025-11-24T21:20:57.909Z

Learnt from: CR
Repo: shapeshift/web PR: 0
File: .cursor/rules/swapper.mdc:0-0
Timestamp: 2025-11-24T21:20:57.909Z
Learning: Applies to packages/swapper/src/swappers/*/*.ts : Reuse executeEvmTransaction utility for EVM-based swappers instead of implementing custom transaction execution

Applied to files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

📚 Learning: 2025-11-24T21:20:57.909Z

Learnt from: CR
Repo: shapeshift/web PR: 0
File: .cursor/rules/swapper.mdc:0-0
Timestamp: 2025-11-24T21:20:57.909Z
Learning: Applies to packages/swapper/src/swappers/*/endpoints.ts : All swapper API implementations must implement the SwapperApi interface from packages/swapper/src/types.ts

Applied to files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

📚 Learning: 2025-12-04T11:05:01.112Z

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 11281
File: packages/swapper/src/swappers/PortalsSwapper/utils/fetchSquidStatus.ts:98-106
Timestamp: 2025-12-04T11:05:01.112Z
Learning: In packages/swapper/src/swappers/PortalsSwapper/utils/fetchSquidStatus.ts, getSquidTrackingLink should return blockchain explorer links (using Asset.explorerTxLink) rather than API endpoints. For non-GMP Squid swaps: return source chain explorer link with sourceTxHash when pending/failed, and destination chain explorer link with destinationTxHash when confirmed.

Applied to files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

📚 Learning: 2025-11-24T21:20:57.909Z

Learnt from: CR
Repo: shapeshift/web PR: 0
File: .cursor/rules/swapper.mdc:0-0
Timestamp: 2025-11-24T21:20:57.909Z
Learning: Applies to packages/swapper/src/swappers/**/*.ts : Avoid side effects in swap logic; ensure swap methods are deterministic and stateless

Applied to files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

📚 Learning: 2025-11-24T21:20:57.909Z

Learnt from: CR
Repo: shapeshift/web PR: 0
File: .cursor/rules/swapper.mdc:0-0
Timestamp: 2025-11-24T21:20:57.909Z
Learning: Applies to packages/swapper/**/*.test.ts : Write unit tests for swapper methods and API endpoints

Applied to files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

📚 Learning: 2025-11-24T21:20:57.909Z

Learnt from: CR
Repo: shapeshift/web PR: 0
File: .cursor/rules/swapper.mdc:0-0
Timestamp: 2025-11-24T21:20:57.909Z
Learning: Applies to packages/swapper/**/*.ts : Use TypeScript with explicit types (e.g., SupportedChainIds) for all code in the Swapper system

Applied to files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

📚 Learning: 2025-11-24T21:20:17.804Z

Learnt from: CR
Repo: shapeshift/web PR: 0
File: .cursor/rules/error-handling.mdc:0-0
Timestamp: 2025-11-24T21:20:17.804Z
Learning: Applies to **/swapper{s,}/**/*.{ts,tsx} : ALWAYS use `makeSwapErrorRight` for swapper errors with `TradeQuoteError` enum for error codes and provide detailed error information

Applied to files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

📚 Learning: 2025-12-01T22:01:37.982Z

Learnt from: gomesalexandre
Repo: shapeshift/web PR: 11240
File: packages/swapper/src/swappers/CetusSwapper/endpoints.ts:56-58
Timestamp: 2025-12-01T22:01:37.982Z
Learning: In packages/swapper/src/swappers/CetusSwapper/endpoints.ts, gomesalexandre is comfortable with mutating the shared Cetus SDK singleton instance (sdk.senderAddress = from) when required by the SDK API, preferring pragmatic working code over theoretical statelessness concerns.

Applied to files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

📚 Learning: 2025-11-24T21:20:57.909Z

Learnt from: CR
Repo: shapeshift/web PR: 0
File: .cursor/rules/swapper.mdc:0-0
Timestamp: 2025-11-24T21:20:57.909Z
Learning: Applies to packages/swapper/src/swappers/**/*.ts : Validate inputs and log errors for debugging in Swapper system implementations

Applied to files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

📚 Learning: 2025-08-22T12:58:26.590Z

Learnt from: NeOMakinG
Repo: shapeshift/web PR: 10323
File: src/components/Layout/Header/ActionCenter/components/GenericTransactionActionCard.tsx:108-111
Timestamp: 2025-08-22T12:58:26.590Z
Learning: In the RFOX GenericTransactionDisplayType flow in src/components/Layout/Header/ActionCenter/components/GenericTransactionActionCard.tsx, the txHash is always guaranteed to be present according to NeOMakinG, so defensive null checks for txLink are not needed in this context.

Applied to files:

• packages/swapper/src/swappers/SunioSwapper/endpoints.ts

📚 Learning: 2025-11-24T21:20:04.979Z

Learnt from: CR
Repo: shapeshift/web PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T21:20:04.979Z
Learning: Applies to **/*.{ts,tsx} : Use Chakra UI components and conventions

Applied to files:

• src/pages/SplashScreen/SplashScreen.tsx

📚 Learning: 2025-08-08T14:59:40.422Z

Learnt from: NeOMakinG
Repo: shapeshift/web PR: 10231
File: src/pages/Explore/ExploreCategory.tsx:231-238
Timestamp: 2025-08-08T14:59:40.422Z
Learning: In src/pages/Explore/ExploreCategory.tsx, for the PageHeader filter trigger, NeOMakinG considers changing a clickable Chakra Icon to IconButton too nitpicky for this PR and prefers to keep the current Icon-based trigger; such minor a11y/UI nitpicks should be deferred to a follow-up if needed.

Applied to files:

• src/pages/SplashScreen/SplashScreen.tsx

🧬 Code graph analysis (1)

packages/swapper/src/swappers/SunioSwapper/endpoints.ts (1)

packages/swapper/src/utils.ts (1)

• createDefaultStatusResponse (197-201)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Call / Static

🔇 Additional comments (3)

packages/unchained-client/src/tron/types.ts (1)

29-32: LGTM! Type definition aligns with TRON's transaction result structure.

The optional ret property correctly models TRON's transaction receipt format, supporting status checking via contractRet and fee information. The union type for contractRet appropriately handles both known states ('SUCCESS', 'REVERT') and potential future values.

packages/swapper/src/swappers/SunioSwapper/endpoints.ts (1)

168-196: LGTM! Properly implements transaction status checking with confirmations guard.

The refactored implementation:

• Uses the adapter's getTransaction method instead of manual REST calls
• Correctly requires confirmations > 0 in addition to SUCCESS status before marking as Confirmed
• Provides clear three-way status determination (Confirmed/Failed/Pending)
• Handles errors gracefully by returning a default status

This aligns with the PR objective of waiting for actual block confirmations before marking swaps complete.

src/pages/SplashScreen/SplashScreen.tsx (1)

4-4: No Vite configuration changes needed – SVG import works correctly.

The change from @/assets/orbs.svg?url to @/assets/orbs.svg is valid and works as intended. Vite's default behavior for static assets (including SVGs) is to return a string path, making the ?url suffix redundant. This pattern is already widely used throughout the codebase in similar contexts (e.g., rewards.svg, risk.svg, withdraw.svg in CosmosLearnMore.tsx, and multiple SVG imports in MobileConnect.tsx and other components). Line 17's template literal usage will work correctly with the import returning a string path.

Likely an incorrect or invalid review comment.

[NeOMakinG]

https://jam.dev/c/6ddf58b9-2554-4a47-b15d-1fa65a3614dd

Thats my boy