Ep site section#104
Conversation
|
|
||
| &.mentorship { | ||
| //mentorship-specific styles here | ||
| background-color: blue; // temp color |
There was a problem hiding this comment.
These comments and temporary colors are fine for now. We'll finesse when everything is merged into the entry-page branch.
| } | ||
|
|
||
| //use this for larger screen sizes, define the width of the screen in _variables.scss | ||
| @media (min-width: $width-lg) { |
There was a problem hiding this comment.
Looks like this isn't being used. I'll nuke it after the merge.
| } | ||
| } | ||
|
|
||
| //testing only -- this is not the "real" featured-list |
There was a problem hiding this comment.
This should be nuked, too.
| <a href="#">arrow goes here</a> | ||
| </div> | ||
|
|
||
| <!--featured list component goes here --> |
There was a problem hiding this comment.
Thanks for the comment here. :)
| @@ -1,5 +1,49 @@ | |||
| <%# render "layouts/navbar", page: "" %> | |||
| <!--base section --> | |||
There was a problem hiding this comment.
I'll clean this up after merge so you don't have to mess with it.
nickirios
left a comment
nickirios
left a comment
There was a problem hiding this comment.
Nuke the ruby changes, and this'll be good to go. :)
| @@ -0,0 +1,16 @@ | |||
| require "rails_helper" | |||
There was a problem hiding this comment.
I don't remember modifying any ruby. I don't think this should be here. Can you remove this file from the PR?
| @@ -0,0 +1,77 @@ | |||
| # This file is copied to spec/ when you run 'rails generate rspec:install' | |||
There was a problem hiding this comment.
Same here. Remove this file for the PR, please.
| @@ -0,0 +1,99 @@ | |||
| # This file was generated by the `rails generate rspec:install` command. Conventionally, all | |||
There was a problem hiding this comment.
Remove this one from the PR, too.
| @@ -0,0 +1,43 @@ | |||
| require 'spec_helper' | |||
There was a problem hiding this comment.
Remove this one from the PR, too.
3 participants
This checkin is for the site-section ticket from Trello (https://trello.com/c/QQ5QNzSE/1-site-section-c). Added incomplete arrow mixin that will be used in this component. Colors and final finessing is needed for the site section styles.