Skip to content

RPC タイムアウトの処理を修正する #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melpon merged 7 commits into from
Feb 13, 2026
Merged

RPC タイムアウトの処理を修正する #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f3def1f
タイムアウトに 0 を許容する
melpon Feb 12, 2026
88dc661
Canceled は不要
melpon Feb 12, 2026
75e7d4c
ResponseReceived → Response
melpon Feb 12, 2026
39c5a93
無駄なロックを削除したりコメントを修正したりなど
melpon Feb 12, 2026
e735b49
null チェックはやめる
melpon Feb 12, 2026
dd9d1ec
細かいとこを修正
melpon Feb 12, 2026
02b8d89
RpcCallback も DispatchEvent で発生するのでロックは完全に不要
melpon Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SoraUnitySdkExamples/.vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,5 @@
"temp/": true,
"Temp/": true
},
"dotnet.defaultSolution": "SoraUnitySdkExamples.sln"
"dotnet.defaultSolution": "SoraUnitySdkExamples.slnx"
}
12 changes: 2 additions & 10 deletions SoraUnitySdkExamples/Assets/SoraSample.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1206,15 +1206,12 @@ void HandleRpcResult(Sora.RpcResult result)
{
switch (result.ResultKind)
{
case Sora.RpcResultKind.ResponseReceived:
case Sora.RpcResultKind.Response:
Debug.LogFormat("RPC response: method={0}, response={1}", result.Method, result.ResponseJson);
break;
case Sora.RpcResultKind.Timeout:
Debug.LogErrorFormat("RPC timeout: method={0}", result.Method);
break;
case Sora.RpcResultKind.Canceled:
Debug.LogWarningFormat("RPC canceled: method={0}", result.Method);
break;
}
}

Expand All @@ -1227,7 +1224,7 @@ void RequestRpcWithInspectorSettings(string method, string paramsJson)

if (string.IsNullOrWhiteSpace(rpcTimeoutMillis))
{
sora.RequestRpc(method, paramsJson, HandleRpcResult);
sora.RequestRpc(method, paramsJson, HandleRpcResult, Sora.DefaultRpcTimeoutMillis);
return;
}

Expand All @@ -1237,11 +1234,6 @@ void RequestRpcWithInspectorSettings(string method, string paramsJson)
Debug.LogErrorFormat("RPC timeoutMillis の形式が不正です: timeoutMillis={0}", rpcTimeoutMillis);
return;
}
if (timeoutMillis <= 0)
{
Debug.LogErrorFormat("RPC timeoutMillis は 1 以上を指定してください: timeoutMillis={0}", timeoutMillis);
return;
}

sora.RequestRpc(method, paramsJson, HandleRpcResult, timeoutMillis);
}
Expand Down
Loading