Mark Highligher.codeToHtml as non-nullable#114
Merged
orta merged 1 commit intoshikijs:masterfrom Jan 25, 2021
Merged
Conversation
Contributor
|
Yeah, I also can't see a reason why this would be nullable. Let's do it. |
Member
Author
|
How about we release to npm a version with this and #108 ? |
Member
Author
|
For future reference: This has been shipped as part of 0.9.0. |
leafac
added a commit
to leafac/rehype-shiki
that referenced
this pull request
Feb 4, 2021
antfu
added a commit
that referenced
this pull request
Jan 26, 2024
Co-authored-by: Anthony Fu <github@antfu.me> Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101
/cc @octref @orta