Skip to content

feat: add stata lang#281

Merged
octref merged 2 commits intoshikijs:mainfrom
kylebutts:main
Dec 31, 2021
Merged

feat: add stata lang#281
octref merged 2 commits intoshikijs:mainfrom
kylebutts:main

Conversation

@kylebutts
Copy link
Contributor

@kylebutts kylebutts commented Dec 28, 2021

Add Stata support from the fantastic work from @kylebarron

  • I have read docs for adding a language.
  • I have searched around and this is the most up-to-date, actively maintained version of the language grammar.
  • I have added a sample file that includes a variety of language syntaxes and succinctly captures the idiosyncrasy of a language. See docs for requirement.

octref
octref approved these changes Dec 31, 2021
View reviewed changes
Copy link
Collaborator

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the unrelated changes to latex/tex.

@octref octref merged commit 5119d74 into shikijs:main Dec 31, 2021
@octref
Copy link
Collaborator

octref commented Dec 31, 2021

Thanks!

@kylebutts kylebutts mentioned this pull request Jan 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@octref octref octref approved these changes

Assignees

No one assigned

Labels

languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kylebutts @octref