Add support for the css-variables theme to ansi rendering#435
Merged
octref merged 3 commits intoshikijs:mainfrom Apr 22, 2023
Merged
Add support for the css-variables theme to ansi rendering#435octref merged 3 commits intoshikijs:mainfrom
octref merged 3 commits intoshikijs:mainfrom
Conversation
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
5b96e1d to
245e9b1
Compare
Contributor
Author
|
@octref would you please take a look at this PR? |
b26f8fe to
f81be81
Compare
octref
approved these changes
Apr 22, 2023
Collaborator
octref
left a comment
There was a problem hiding this comment.
Looking good. Thanks for the contribution and sorry for my delay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized while integrating the recent ANSI support into Nextra that Nextra uses the css-variables functionality which was not working with ANSI colors. I've updated the default color replacements and css-variables theme to support ANSI colors and updated the ANSI tokenizer to use a separate
-dimvariable for dimmed colors since we can no longer add opacity ourselves.