Skip to content

Add support for the css-variables theme to ansi rendering#435

Merged
octref merged 3 commits intoshikijs:mainfrom
blake-mealey:ansi-css-variables
Apr 22, 2023
Merged

Add support for the css-variables theme to ansi rendering#435
octref merged 3 commits intoshikijs:mainfrom
blake-mealey:ansi-css-variables

Conversation

@blake-mealey
Copy link
Contributor

@blake-mealey blake-mealey commented Feb 18, 2023

I realized while integrating the recent ANSI support into Nextra that Nextra uses the css-variables functionality which was not working with ANSI colors. I've updated the default color replacements and css-variables theme to support ANSI colors and updated the ANSI tokenizer to use a separate -dim variable for dimmed colors since we can no longer add opacity ourselves.

  • This PR fixes #
  • I have read docs for adding a language.
  • I have searched around and this is the most up-to-date, actively maintained version of the language grammar.
  • I have added a sample file that includes a variety of language syntaxes and succinctly captures the idiosyncrasy of a language. See docs for requirement.

@netlify
Copy link

netlify bot commented Feb 18, 2023

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit f81be81
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/64446473318b6d00082cdc07
😎 Deploy Preview https://deploy-preview-435--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@blake-mealey blake-mealey marked this pull request as ready for review February 18, 2023 19:49
@blake-mealey
Copy link
Contributor Author

@octref would you please take a look at this PR?

@octref octref force-pushed the ansi-css-variables branch from b26f8fe to f81be81 Compare April 22, 2023 22:49
Copy link
Collaborator

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thanks for the contribution and sorry for my delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants