Add an option to skip generating the explanation text#52
Merged
octref merged 2 commits intoshikijs:masterfrom Aug 20, 2020
Merged
Add an option to skip generating the explanation text#52octref merged 2 commits intoshikijs:masterfrom
octref merged 2 commits intoshikijs:masterfrom
Conversation
octref
force-pushed
the
perf/explanation
branch
from
2669d11 to
4c45c54
Compare
octref
force-pushed
the
perf/explanation
branch
from
4c45c54 to
b1fe16c
Compare
octref
approved these changes
Aug 20, 2020
Collaborator
octref
left a comment
octref
left a comment
There was a problem hiding this comment.
Good work! I didn't bother to explain the API earlier since it's simple and mostly documented on the website, but now I think it's better to add some explanations.
octref
added a commit
that referenced
this pull request
Aug 20, 2020
antfu
added a commit
that referenced
this pull request
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As alluded to in #51, there are still lots of string copies that aren't necessarily required when tokenizing due to including the explanation for each token's color. This adds an option which can be used to disable the explanation generation if not required.
Since this builds on the changes in #51, it is also included in this PR.