Skip to content

feat: slack themes#78

Merged
octref merged 2 commits intoshikijs:masterfrom
codepunkt:slack_themes
Sep 2, 2020
Merged

feat: slack themes#78
octref merged 2 commits intoshikijs:masterfrom
codepunkt:slack_themes

Conversation

@codepunkt
Copy link
Contributor

Fixes #75

@octref
Copy link
Collaborator

octref commented Aug 25, 2020

Sorry, I just realized that I didn't finish the script. Can you rebase off master and run yarn:update-themes again?
Also, why only choose two of the themes?

@codepunkt
Copy link
Contributor Author

Wasn't sure how many you'd want. Those are the two that i'm using. I can add all of them for a better/full experience. Should i?

@octref
Copy link
Collaborator

octref commented Sep 1, 2020

Can you please only add ochin? I think all the themes have same syntax highlighting, just different workspace colors.
Aubergine dark is the only one with different syntax highlighting, but it doesn't look that good to me.

@codepunkt
Copy link
Contributor Author

That doesn't fit my usecase. I need two of them, and a good solution to switch between them for light/dark mode.

If this is not mergeable here, i'll use my fork.

@octref octref force-pushed the slack_themes branch 2 times, most recently from 530d089 to 696c38d Compare September 2, 2020 02:21
@octref
Copy link
Collaborator

octref commented Sep 2, 2020

That doesn't fit my usecase. I need two of them, and a good solution to switch between them for light/dark mode.

OK, that makes sense.

There's a script to update theme source https://github.com/shikijs/shiki/blob/master/scripts/pullGHThemes.sh#L6

I rebased off origin/master and made the necessary changes.

@octref octref closed this Sep 2, 2020
@octref octref reopened this Sep 2, 2020
@octref octref merged commit 8b1c9c9 into shikijs:master Sep 2, 2020
@codepunkt
Copy link
Contributor Author

Awesome, thanks @octref! 👍
Whenever you decide you'd also want to have the other Slack themes, i can do that.

antfu pushed a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "slack" themes

2 participants