Skip to content

Fix default color highlighting in VS Code Dark#81

Closed
karlhorky wants to merge 1 commit intoshikijs:masterfrom
karlhorky:patch-1
Closed

Fix default color highlighting in VS Code Dark#81
karlhorky wants to merge 1 commit intoshikijs:masterfrom
karlhorky:patch-1

Conversation

@karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Aug 26, 2020

Hi @octref, thanks for this library, really cool!

It seems like the VS Code Dark default color highlighting is broken again, which was previously reported and fixed here:

Original Issue: #45
Original PR: #64

Potentially broken by something around: 9fc790e#diff-3934a4a9ee6eb5b09946d87cdb31e5f4

I guess there should be an automated way of adding this one back, to prevent future breakages.

See the problem in the example CodeSandbox here: https://codesandbox.io/s/kind-wildflower-mrx10?file=/pages/index.js

Screen Shot 2020-08-26 at 12 08 44

Original Issue: #45
Original PR: #64

Potentially broken by something around: 9fc790e#diff-3934a4a9ee6eb5b09946d87cdb31e5f4
@octref
Copy link
Collaborator

octref commented Aug 26, 2020

I sent an upstream PR: microsoft/vscode#105418

Meanwhile, the update need to happen on the automation code, otherwise the scheduled run would pull in the wrong theme again.

@octref
Copy link
Collaborator

octref commented Aug 26, 2020

Thanks for spotting the bug, but sorry the correct fix should be: 7598345

I triggered a new action which would update the themes once again.

@octref octref closed this Aug 26, 2020
@karlhorky
Copy link
Contributor Author

I sent an upstream PR

Meanwhile, the update need to happen on the automation code, otherwise the scheduled run would pull in the wrong theme again

sorry the correct fix should be

No problem, I had a feeling this was just a temporary patch that may break again.

Thanks for all the work getting it done correctly!

@karlhorky karlhorky deleted the patch-1 branch August 26, 2020 15:52
antfu pushed a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants