Fix default color highlighting in VS Code Dark#81
Closed
karlhorky wants to merge 1 commit intoshikijs:masterfrom
karlhorky:patch-1
Closed
Fix default color highlighting in VS Code Dark#81karlhorky wants to merge 1 commit intoshikijs:masterfrom karlhorky:patch-1
karlhorky wants to merge 1 commit intoshikijs:masterfrom
karlhorky:patch-1
Conversation
Original Issue: #45 Original PR: #64 Potentially broken by something around: 9fc790e#diff-3934a4a9ee6eb5b09946d87cdb31e5f4
Collaborator
|
I sent an upstream PR: microsoft/vscode#105418 Meanwhile, the update need to happen on the automation code, otherwise the scheduled run would pull in the wrong theme again. |
Collaborator
|
Thanks for spotting the bug, but sorry the correct fix should be: 7598345 I triggered a new action which would update the themes once again. |
Contributor
Author
No problem, I had a feeling this was just a temporary patch that may break again. Thanks for all the work getting it done correctly! |
antfu
pushed a commit
that referenced
this pull request
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @octref, thanks for this library, really cool!
It seems like the VS Code Dark default color highlighting is broken again, which was previously reported and fixed here:
Original Issue: #45
Original PR: #64
Potentially broken by something around: 9fc790e#diff-3934a4a9ee6eb5b09946d87cdb31e5f4
I guess there should be an automated way of adding this one back, to prevent future breakages.
See the problem in the example CodeSandbox here: https://codesandbox.io/s/kind-wildflower-mrx10?file=/pages/index.js