Require PHP 8.1+ and modernize codebase#18
Open
janedbal wants to merge 2 commits into
Open
Conversation
Drop PHP 7.4/8.0 support and align with recent shipmonk OS lib upgrades (dead-code-detector, input-mapper, composer-dependency-analyser): - composer: require php ^8.1, phpunit ^10.5, dead-code-detector ^1.0; add editorconfig-checker with a check:ec step in `composer check` - phpunit.xml.dist: migrate to the PHPUnit 10 schema - phpcs: php_version 80100; drop PHP 7.4-era trailing-comma and @dataProvider workarounds so the standard's defaults apply - phpstan: phpVersion range 80100-80599 - RuleTestCase: use str_starts_with(); add now-required trailing commas - CI: drop 7.4/8.0 from the matrix Co-Authored-By: Claude Code Claude-Session: https://claude.ai/code/session_01PC9VQVcZV1UEDBSUusQ79g
editorconfig-checker has no installable Windows binary (its release asset 404s), so the full `composer check` cannot run on Windows — same reason sibling libs only lint on Linux. Keep Windows coverage for the DIRECTORY_SEPARATOR path logic by running the test suite there. Co-Authored-By: Claude Code Claude-Session: https://claude.ai/code/session_01PC9VQVcZV1UEDBSUusQ79g
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops PHP 7.4/8.0 support and aligns the project with the recent upgrades of sibling shipmonk OS libs (
dead-code-detector,input-mapper,composer-dependency-analyser).Changes
php: ^8.1, bumpphpunit/phpunitto^10.5,shipmonk/dead-code-detectorto^1.0; addeditorconfig-checker/editorconfig-checkerwith acheck:ecstep wired intocomposer check. Dropped the now-invalid-vvvflag fromcheck:tests(removed in PHPUnit 10).beStrictAboutCoversAnnotation,beStrictAboutTodoAnnotatedTests,cacheResultFile), switched tocacheDirectory, added<testsuites>/<source>and the modernfailOn*/displayDetailsOn*strictness flags.php_version→80100; removed the two PHP-7.4-era workarounds (the@dataProvider/AnnotationForbiddenexclusion and theDisallowTrailingCommaInDeclaration onlySingleLine=falseoverride) so the standard's defaults apply.phpVersionrange →80100–80599.str_starts_with()instead ofstrpos(...) === 0; add the trailing commas now required in multi-line declarations.7.4/8.0. Fullcomposer checkruns across the Linux × PHP 8.1–8.5 matrix; a separate Windows job runs the test suite (Windows keeps coverage of theDIRECTORY_SEPARATORpath logic but cannot runeditorconfig-checker, whose release ships no installable Windows binary — same reason sibling libs only lint on Linux).composer checkpasses locally (also enforced by the pre-commit hook).Co-Authored-By: Claude Code