Skip to content

[fix] BitmapFileWatcher delete old files#18

Merged
shixinzhang merged 1 commit into
shixinzhang:masterfrom
awxy:fix/deleting_old_files
Nov 20, 2023
Merged

[fix] BitmapFileWatcher delete old files#18
shixinzhang merged 1 commit into
shixinzhang:masterfrom
awxy:fix/deleting_old_files

Conversation

@awxy
Copy link
Copy Markdown
Contributor

@awxy awxy commented Oct 31, 2023

This commit fixes a bug where the modification time of files was altered when deleting old files

stack :

10-31 17:42:36.919 12552 14353 E AndroidRuntime: java.lang.IllegalArgumentException: Comparison method violates its general contract!
10-31 17:42:36.919 12552 14353 E AndroidRuntime: at java.util.TimSort.mergeHi(TimSort.java:899)
10-31 17:42:36.919 12552 14353 E AndroidRuntime: at java.util.TimSort.mergeAt(TimSort.java:516)
10-31 17:42:36.919 12552 14353 E AndroidRuntime: at java.util.TimSort.mergeCollapse(TimSort.java:439)
10-31 17:42:36.919 12552 14353 E AndroidRuntime: at java.util.TimSort.sort(TimSort.java:245)
10-31 17:42:36.919 12552 14353 E AndroidRuntime: at java.util.Arrays.sort(Arrays.java:1424)
10-31 17:42:36.919 12552 14353 E AndroidRuntime: at java.util.concurrent.CopyOnWriteArrayList.sort(CopyOnWriteArrayList.java:882)
10-31 17:42:36.919 12552 14353 E AndroidRuntime: at top.shixinzhang.bitmapmonitor.internal.BitmapFileWatcher.deleteFileFromRootDirectory(BitmapFileWatcher.java:126)
10-31 17:42:36.919 12552 14353 E AndroidRuntime: at top.shixinzhang.bitmapmonitor.internal.BitmapFileWatcher.access$400(BitmapFileWatcher.java:20)
10-31 17:42:36.919 12552 14353 E AndroidRuntime: at top.shixinzhang.bitmapmonitor.internal.BitmapFileWatcher$WatchFileRunnable.run(BitmapFileWatcher.java:201)
10-31 17:42:36.919 12552 14353 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
10-31 17:42:36.919 12552 14353 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
10-31 17:42:36.919 12552 14353 E AndroidRuntime: at java.lang.Thread.run(Thread.java:920)

@shixinzhang shixinzhang merged commit e396f62 into shixinzhang:master Nov 20, 2023
@shixinzhang
Copy link
Copy Markdown
Owner

@awxy Thanks for your commit !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants