Skip to content

ci: pull upstream's fixed freeze.yml (broken YAML on stable)#156

Merged
eseidel merged 1 commit into
shorebird/devfrom
es/fix-freeze-yaml
Jun 2, 2026
Merged

ci: pull upstream's fixed freeze.yml (broken YAML on stable)#156
eseidel merged 1 commit into
shorebird/devfrom
es/fix-freeze-yaml

Conversation

@eseidel

@eseidel eseidel commented Jun 2, 2026

Copy link
Copy Markdown

What

Replace .github/workflows/freeze.yml with upstream flutter/flutter's current version.

Why

The copy synced into shorebird/dev is broken YAML: line 68's run: echo "...override: code freeze..." makes the parser read the : as a mapping key (mapping values are not allowed here, line 68 col 54). As a result the workflow fails to parse and reports a failed run on every push to shorebird/dev (visible 06-01, 06-02, …) — including on unrelated PRs.

We never modified this file (it's upstream-owned). Upstream has since fixed it (dropped the colon-bearing label + the offending steps). Pulling their current version:

  • makes it parse → stops the per-push red, and
  • keeps the file aligned with upstream, so it won't conflict on the next sync (vs. deleting it, which upstream would just re-add).

It remains gated to github.repository == 'flutter/flutter', so it's still a no-op on our fork — this is purely fixing the parse failure.

Verified: python -c 'yaml.safe_load(...)' passes on the new file. Unrelated to (but unblocks the CI noise on) the dart-sdk consumption PR #155.

freeze.yml synced from upstream in a broken state: line 68's
`run: echo "...override: code freeze..."` makes YAML read the colon as a
mapping key, so the workflow fails to parse and reports a failed run on
every push to shorebird/dev. We never modified the file.

Replace it with upstream flutter/flutter's current version, which fixed the
issue (dropped the colon-bearing label + the offending steps). Still gated
to `github.repository == 'flutter/flutter'`, so it remains a no-op on our
fork -- this just stops the per-push red and keeps the file aligned with
upstream (no sync conflict).
@eseidel eseidel requested a review from bdero June 2, 2026 20:59
@eseidel eseidel merged commit 074a156 into shorebird/dev Jun 2, 2026
2 of 6 checks passed
@eseidel eseidel deleted the es/fix-freeze-yaml branch June 2, 2026 21:16
mrnpro pushed a commit to Flutter-Code-Push/flutter that referenced this pull request Jun 16, 2026
…rebirdtech#156)

freeze.yml synced from upstream in a broken state: line 68's
`run: echo "...override: code freeze..."` makes YAML read the colon as a
mapping key, so the workflow fails to parse and reports a failed run on
every push to shorebird/dev. We never modified the file.

Replace it with upstream flutter/flutter's current version, which fixed the
issue (dropped the colon-bearing label + the offending steps). Still gated
to `github.repository == 'flutter/flutter'`, so it remains a no-op on our
fork -- this just stops the per-push red and keeps the file aligned with
upstream (no sync conflict).
bdero pushed a commit that referenced this pull request Jun 22, 2026
freeze.yml synced from upstream in a broken state: line 68's
`run: echo "...override: code freeze..."` makes YAML read the colon as a
mapping key, so the workflow fails to parse and reports a failed run on
every push to shorebird/dev. We never modified the file.

Replace it with upstream flutter/flutter's current version, which fixed the
issue (dropped the colon-bearing label + the offending steps). Still gated
to `github.repository == 'flutter/flutter'`, so it remains a no-op on our
fork -- this just stops the per-push red and keeps the file aligned with
upstream (no sync conflict).
bdero pushed a commit that referenced this pull request Jun 25, 2026
freeze.yml synced from upstream in a broken state: line 68's
`run: echo "...override: code freeze..."` makes YAML read the colon as a
mapping key, so the workflow fails to parse and reports a failed run on
every push to shorebird/dev. We never modified the file.

Replace it with upstream flutter/flutter's current version, which fixed the
issue (dropped the colon-bearing label + the offending steps). Still gated
to `github.repository == 'flutter/flutter'`, so it remains a no-op on our
fork -- this just stops the per-push red and keeps the file aligned with
upstream (no sync conflict).
bdero pushed a commit that referenced this pull request Jul 7, 2026
freeze.yml synced from upstream in a broken state: line 68's
`run: echo "...override: code freeze..."` makes YAML read the colon as a
mapping key, so the workflow fails to parse and reports a failed run on
every push to shorebird/dev. We never modified the file.

Replace it with upstream flutter/flutter's current version, which fixed the
issue (dropped the colon-bearing label + the offending steps). Still gated
to `github.repository == 'flutter/flutter'`, so it remains a no-op on our
fork -- this just stops the per-push red and keeps the file aligned with
upstream (no sync conflict).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants