Skip to content

SG-24020: Fixes a bug in the schedule test #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfboismenu merged 4 commits into from
Sep 23, 2021
Merged

SG-24020: Fixes a bug in the schedule test #250

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
168f9a7
prove that it's broken
Sep 23, 2021
39820d4
fix
Sep 23, 2021
5680fbe
fix-er
Sep 23, 2021
7113093
re-fixed
Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,9 @@ def test_work_schedule(self):
end_date_obj = datetime.datetime(2012, 1, 7)

project = self.project
user = self.sg.find_one('HumanUser', [['projects', 'is', project]], ['name'])
# We're going to be comparing this value with the value returned from the server, so extract only the type
# and id
user = {"type": self.human_user["type"], "id": self.human_user["id"], "name": self.human_user["name"]}

work_schedule = self.sg.work_schedule_read(start_date, end_date, project, user)

Expand Down Expand Up @@ -842,7 +844,7 @@ def test_work_schedule(self):
resp = self.sg.work_schedule_read(start_date, end_date, project, user)
work_schedule['2012-01-04'] = {"reason": "USER_EXCEPTION", "working": False, "description": "Artist Holiday"}
# FIXME: There seems to be a regresion on the Shotgun server that needs to be fixed. Disabling the test
# self.assertEqual(work_schedule, resp)
self.assertEqual(work_schedule, resp)

# For now disable tests that are erroneously failling on some sites to
# allow CI to pass until the known issue causing this is resolved.
Expand Down