SG-32806 Upgrade httplib2 to 0.22.0#305
Merged
carlos-villavicencio-adsk merged 1 commit intomasterfrom Sep 18, 2023
Merged
Conversation
3 tasks
julien-lang
previously approved these changes
Sep 18, 2023
Member
julien-lang
left a comment
julien-lang
left a comment
There was a problem hiding this comment.
LGTM!
Do you have any idea why we use httplib2 anyway?
carlos-villavicencio-adsk
force-pushed
the
ticket/SG-32806_upgrade_httplib2
branch
from
6f652c6 to
9245db8
Compare
carlos-villavicencio-adsk
changed the title
Contributor
Author
@julien-lang probably because of Python 2 support: see this line. Would you mind reviewing this again? I had to force-push to overwrite my last commit in favor of this one. |
julien-lang
approved these changes
Sep 18, 2023
carlos-villavicencio-adsk
deleted the
ticket/SG-32806_upgrade_httplib2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for Python 3.10 we need to upgrade this dependency to remove warnings on CI and potential deprecation.