Test using ShouldBe with dynamic proxy is failing after update to 2.1.0

[vorou]

I'm using Likeness, which creates a dynamic proxy of my object with properly overridden Equals method (it compares all the public props on the object). This assertion is failing after I updated Shouldly to 2.1.0:

actual.ShouldBe(expected.AsSource().OfLikeness<Tender>().CreateProxy());

But it works OK if swap the arguments:

expected.AsSource().OfLikeness<Tender>().CreateProxy().ShouldBe(actual);

The original order is more natural, I guess. It would be cool if there is a way to make it work again.

[JakeGinnivan]

Would you be able to put together a really simple repro as a gist so we can look into it?

[vorou]

Here you are: https://gist.github.com/vorou/9533317.
The lib is SemanticComparison on NuGet.

[JakeGinnivan]

Interesting, basically we should be calling .Equals on the expected rather than the actual because the proxy creates an Equals overload.

@xerxesb can you see any problems with making this change?

[vorou]

@JakeGinnivan yeah, exactly

[JakeGinnivan]

Did you want to have a go and put up a pull request, I am planning to release 2.1.1 in the next day or so, would be good to get this in, but I am short on time atm

[JakeGinnivan]

If you do put it in, would be good to add a test (derived class with overridden Equals as expected which shows the issue off)

[vorou]

Yep, I'll do it.

[vorou]

#124
I'm not used to the test structure used in the project, so please tell me if there's something wrong with my test.

[JakeGinnivan]

Will be released in 2.1.1