Skip to content

Create json tests for crypto consensus testing #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
konradkonrad merged 8 commits into from
Dec 4, 2023
Merged

Create json tests for crypto consensus testing #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7a4f988
Add crypto consensus test infrastructure
konradkonrad Nov 6, 2023
34d2fe7
PR style changes
konradkonrad Nov 9, 2023
bf41886
Change all CI cache keys
konradkonrad Nov 9, 2023
ca1ac4e
Add missing file
konradkonrad Nov 9, 2023
749e786
Change visibility
konradkonrad Nov 14, 2023
56383a2
Upgrade shlib and enable malleability test
konradkonrad Nov 23, 2023
339373d
Rebase after identitypreimage refactor
konradkonrad Nov 23, 2023
4f6c49d
Match dependencies of rolling-shutter/main
konradkonrad Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .circleci/rolling-shutter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
path: ~/src
- restore_cache:
keys:
- rs-generate-v18-{{ checksum "go.sum" }}-{{checksum "go.mod"}}
- rs-generate-v19-{{ checksum "go.sum" }}-{{checksum "go.mod"}}
- install-asdf
- run:
name: "Install asdf plugins"
Expand All @@ -33,7 +33,7 @@ jobs:
find ./docs -name '*.md' -delete
- run: make generate
- save_cache:
key: rs-generate-v18-{{ checksum "go.sum" }}-{{checksum "go.mod"}}
key: rs-generate-v19-{{ checksum "go.sum" }}-{{checksum "go.mod"}}
paths:
- "~/go/pkg/mod"
- "~/.cache/go-build"
Expand All @@ -51,10 +51,10 @@ jobs:
path: ~/src
- restore_cache:
keys:
- go-mod-v7-{{ checksum "go.sum" }}-{{ checksum "go.mod" }}
- go-mod-v8-{{ checksum "go.sum" }}-{{ checksum "go.mod" }}
- run: go get -d ./...
- save_cache:
key: go-mod-v7-{{ checksum "go.sum" }}-{{ checksum "go.mod" }}
key: go-mod-v8-{{ checksum "go.sum" }}-{{ checksum "go.mod" }}
paths:
- ~/go/pkg/
- restore_cache:
Expand Down Expand Up @@ -90,7 +90,7 @@ jobs:
- store_test_results:
path: report
- save_cache:
key: rs-build-<< parameters.go-version >>-v4-{{ checksum "go.sum" }}-{{ checksum "go.mod" }}
key: rs-build-<< parameters.go-version >>-v5-{{ checksum "go.sum" }}-{{ checksum "go.mod" }}
paths:
- "~/.cache/go-build"

Expand Down Expand Up @@ -200,7 +200,7 @@ jobs:
- run: |
make lint-changes
- save_cache:
key: rs-lint-v13-{{ checksum "go.sum" }}-{{ checksum "go.mod" }}
key: rs-lint-v14-{{ checksum "go.sum" }}-{{ checksum "go.mod" }}
paths:
- "~/.cache/go-build"
- "~/.cache/golangci-lint"
Expand Down
6 changes: 5 additions & 1 deletion rolling-shutter/cmd/cryptocmd/cryptocmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,23 @@ var (
epochIDFlag string
sigmaFlag string
threshold uint64
filename string
)

func Cmd() *cobra.Command {
cmd := &cobra.Command{
Use: "crypto",
Short: "CLI tool to access crypto functions",
Long: `This command provides utility functions to manually encrypt messages with an eon
key, decrypt them with a decryption key, and check that a decryption key is correct.`,
key, decrypt them with a decryption key, and check that a decryption key is correct. It also hosts
a tool to generate and run crypto tests in a JSON formatted collection.`,
}
cmd.AddCommand(encryptCmd())
cmd.AddCommand(decryptCmd())
cmd.AddCommand(verifyKeyCmd())
cmd.AddCommand(aggregateCmd())
cmd.AddCommand(GenerateTestdata())
cmd.AddCommand(RunJSONTests())

@jannikluhn jannikluhn Nov 8, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this shouldn't be a command, but rather a normal test that can be run with go test. It could get the test file from a path from an environment variable. This would avoid the unusual signature of the ReadTestCases (that panics on read errors and returns multiple error values) and it would be easier to run them in CI.

This is probably something we would want to change in a future PR though, just so that we can get the test generator out quicker.

return cmd
}

Expand Down
Loading